|
Description
Katrin Fischer
2016-08-07 14:01:49 UTC
Created attachment 54123 [details] [review] Bug 17074: Fix links in result list of 'scan indexes' and keep search term visible The 'scan indexes' search that can be reached from the advanced search has 2 problems to begin with: - The search term you searched for is not displayed in the input field. - The links in the result list are missing the index and because of that, are not giving the correct results. To test: - Go to the advanced search, select an index to search in - Enter a search term and check 'scan indexes' - Submit search - Check if the search term is visible in the input box - Check if the result links contain your selected index and give you correct results (count and the number of results should match) (In reply to Katrin Fischer from comment #1) > Created attachment 54123 [details] [review] [review] > Bug 17074: Fix links in result list of 'scan indexes' and keep search term > visible > > The 'scan indexes' search that can be reached from the > advanced search has 2 problems to begin with: > > - The search term you searched for is not displayed > in the input field. > - The links in the result list are missing the index > and because of that, are not giving the correct results. > > To test: > - Go to the advanced search, select an index to search in > - Enter a search term and check 'scan indexes' > - Submit search > - Check if the search term is visible in the input box > - Check if the result links contain your selected index > and give you correct results (count and the number of > results should match) Katrin, I would like to sign off on this, but as far as I can tell, the patch only addresses the links. I can't confirm an issue with the counts, most likely because of the limited number of records I have at the moment, so for that, someone else should test at this time. Also, I see no change with the search term in the input box, unless I am looking at the wrong thing. To me, on this page, the input box should be the textbox labeled "Scan Index for:". If this is the case, the box is still blank, and therefore does not pass your test plan. Please clarify. Thank you. I am not sure what it could be, it works for me. Can please someone else take another look to get a better picture? The counts are correct, the problem is when you click on the link and it's missing the index to search in - so it does a keyword search. So say you did a search for Author, then the counts will show the counts in the author index, but the link would start a keyword search which is likely to give you a different number of results. Best to test this not using the 'keyword' option Christopher, I tried various searches - the "Scan Index for:" is always set for me with the patch applied. I tried different indexes. I would be interested to see your link to the page when it doesn't work. Also, could you check the patch applied nicely? Hm, just found a little problem - if you enter 2 search terms, you will see something like: all%20this - url encoded... I have to check on how to fix this. Created attachment 54133 [details] [review] Bug 17028: Follow-up: fixing encoding issues with multiple search terms If there was more than one search term you could see that that it was url encoded. Also problems with search terms with umlauts and other diacritics. Patch should fix that. Created attachment 54134 [details] [review] Bug 17074: Fix links in result list of 'scan indexes' and keep search term visible The 'scan indexes' search that can be reached from the advanced search has 2 problems to begin with: - The search term you searched for is not displayed in the input field. - The links in the result list are missing the index and because of that, are not giving the correct results. To test: - Go to the advanced search, select an index to search in - Enter a search term and check 'scan indexes' - Submit search - Check if the search term is visible in the input box - Check if the result links contain your selected index and give you correct results (count and the number of results should match) Created attachment 54135 [details] [review] Bug 17074: Follow-up: fixing encoding issues with multiple search terms If there was more than one search term you could see that that it was url encoded. Also problems with search terms with umlauts and other diacritics. Patch should fix that. Created attachment 54138 [details] [review] Bug 17074: Fix links in result list of 'scan indexes' and keep search term visible The 'scan indexes' search that can be reached from the advanced search has 2 problems to begin with: - The search term you searched for is not displayed in the input field. - The links in the result list are missing the index and because of that, are not giving the correct results. To test: - Go to the advanced search, select an index to search in - Enter a search term and check 'scan indexes' - Submit search - Check if the search term is visible in the input box - Check if the result links contain your selected index and give you correct results (count and the number of results should match) Tested both patches together, works as expected. Signed-off-by: Marc <veron@veron.ch> Created attachment 54139 [details] [review] Bug 17074: Follow-up: fixing encoding issues with multiple search terms If there was more than one search term you could see that that it was url encoded. Also problems with search terms with umlauts and other diacritics. Patch should fix that. https://bugs.koha-community.org/show_bug.cgi?id=17074 Signed-off-by: Marc <veron@veron.ch> Created attachment 54190 [details] [review] Bug 17074: Fix links in result list of 'scan indexes' and keep search term visible The 'scan indexes' search that can be reached from the advanced search has 2 problems to begin with: - The search term you searched for is not displayed in the input field. - The links in the result list are missing the index and because of that, are not giving the correct results. To test: - Go to the advanced search, select an index to search in - Enter a search term and check 'scan indexes' - Submit search - Check if the search term is visible in the input box - Check if the result links contain your selected index and give you correct results (count and the number of results should match) Tested both patches together, works as expected. Signed-off-by: Marc <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Created attachment 54191 [details] [review] Bug 17074: Follow-up: fixing encoding issues with multiple search terms If there was more than one search term you could see that that it was url encoded. Also problems with search terms with umlauts and other diacritics. Patch should fix that. https://bugs.koha-community.org/show_bug.cgi?id=17074 Signed-off-by: Marc <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 16.11, thanks Katrin! Pushed in 16.05. Will be in 16.05.03. Pushed to 3.22.x, will be in 3.22.10 |