Bug 17128

Summary: summary-print.pl is not plack safe
Product: Koha Reporter: Jonathan Druart <jonathan.druart+koha>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart+koha>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: frederic, julian.maurice, kyle, veron
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 7172    
Attachments: Bug 17128: Make summary-print.pl plack safe
Bug 17128: Make summary-print.pl plack safe
[PASSED QA] Bug 17128: Make summary-print.pl plack safe

Description Jonathan Druart 2016-08-15 14:45:06 UTC
Variable "$borrowernumber" is not available at /home/koha/src/members/summary-print.pl line 101.
Comment 1 Jonathan Druart 2016-08-15 14:50:27 UTC Comment hidden (obsolete)
Comment 2 Marc Véron 2016-08-15 15:13:25 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2016-08-21 19:12:59 UTC
Created attachment 54663 [details] [review]
[PASSED QA] Bug 17128: Make summary-print.pl plack safe

$borrowernumber is used in build_issue_data but not correctly defined
(Variable "$borrowernumber" is not available)

That may cause wrong charge displayed in the summary slip.

Test plan:
- Set rental charge for an item type
- Define a rental discount for that item type in the circ rules
- check in an item matching this rule
Without this patch the charge displayed in the summary slip won't be
calculated with the discount
With this patch applied, the warning in the logs will no longer appear
and the values will be correctly calculated.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer  <katrin.fischer@bsz-bw.de>
Comment 4 Kyle M Hall 2016-09-02 15:22:47 UTC
Pushed to master for 16.11, thanks Jonathan!
Comment 5 Frédéric Demians 2016-09-08 19:49:25 UTC
Pushed in 16.05. Will be in 16.05.04.
Comment 6 Julian Maurice 2016-09-16 06:57:37 UTC
Pushed to 3.22.x, will be in 3.22.11