Description
Nick Clemens (kidclamp)
2016-08-23 15:58:20 UTC
AutoReturnCheckedOutItemForNewCheckoutForgiveFine It looks a bit like all the Koha buzz words in one word :) Could we find something a bit shorter? Created attachment 64260 [details] [review] Bug 17171 - Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation Some libraries don't want to force the librarians to manually confirm each checkout when the item is checked out to another. Instead, they would prefer to be alerted after the fact. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref AutoReturnCheckedOutItems 4) Check an item out to a patron 5) Check the same item out to another patron 6) Note you are not prompted to confirm the checkout, but are instead alerted that is had been checked out to another patron! Patch does not apply. Created attachment 65924 [details] [review] Bug 17171 - Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation Some libraries don't want to force the librarians to manually confirm each checkout when the item is checked out to another. Instead, they would prefer to be alerted after the fact. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref AutoReturnCheckedOutItems 4) Check an item out to a patron 5) Check the same item out to another patron 6) Note you are not prompted to confirm the checkout, but are instead alerted that is had been checked out to another patron! The syspref worked when set to Don't. That was the only confusion in the test plan. Otherwise, works as expected! Patch tested with a sandbox, by Christopher Brannon <cbrannon@cdalibrary.org> Created attachment 65925 [details] [review] Bug 17171 - Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation Some libraries don't want to force the librarians to manually confirm each checkout when the item is checked out to another. Instead, they would prefer to be alerted after the fact. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref AutoReturnCheckedOutItems 4) Check an item out to a patron 5) Check the same item out to another patron 6) Note you are not prompted to confirm the checkout, but are instead alerted that is had been checked out to another patron! Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com> The file cash_register_stats.tt is edited probably by accident - it should be removed from this patch. Created attachment 70766 [details] [review] Bug 17171 - Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation Some libraries don't want to force the librarians to manually confirm each checkout when the item is checked out to another. Instead, they would prefer to be alerted after the fact. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref AutoReturnCheckedOutItems 4) Check an item out to a patron 5) Check the same item out to another patron 6) Note you are not prompted to confirm the checkout, but are instead alerted that is had been checked out to another patron! Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com> (In reply to Josef Moravec from comment #8) > The file cash_register_stats.tt is edited probably by accident - it should > be removed from this patch. Removed and rebased Created attachment 73258 [details] [review] Bug 17171: Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation Some libraries don't want to force the librarians to manually confirm each checkout when the item is checked out to another. Instead, they would prefer to be alerted after the fact. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref AutoReturnCheckedOutItems 4) Check an item out to a patron 5) Check the same item out to another patron 6) Note you are not prompted to confirm the checkout, but are instead alerted that is had been checked out to another patron! Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Had to fix the alphabetic order in sysprefs.sql, but no other complaints ;) 1. It sounds like we should also modify circulation_batch_checkouts.tt 2. Are you sure we want this to apply to SIP and self-checkout? Created attachment 73315 [details] [review] Bug 17171 [QA Followup]: Add message to batch checkout template (In reply to Jonathan Druart from comment #13) > 1. It sounds like we should also modify circulation_batch_checkouts.tt Follow-up submitted! > 2. Are you sure we want this to apply to SIP and self-checkout? Yes, the logic behind this is: if the patron is holding the book, they can check it out. (In reply to Kyle M Hall from comment #15) > (In reply to Jonathan Druart from comment #13) > > 1. It sounds like we should also modify circulation_batch_checkouts.tt > > Follow-up submitted! Thanks > > 2. Are you sure we want this to apply to SIP and self-checkout? > > Yes, the logic behind this is: if the patron is holding the book, they can > check it out. Should not we make it explicit in the syspref's description in that case? (In reply to Kyle M Hall from comment #14) > Created attachment 73315 [details] [review] [review] > Bug 17171 [QA Followup]: Add message to batch checkout template Use patron-title.inc instead. (In reply to Jonathan Druart from comment #17) > (In reply to Kyle M Hall from comment #14) > > Created attachment 73315 [details] [review] [review] [review] > > Bug 17171 [QA Followup]: Add message to batch checkout template > > Use patron-title.inc instead. in circulation.tt as well. Created attachment 87302 [details] [review] Bug 17171: Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation Some libraries don't want to force the librarians to manually confirm each checkout when the item is checked out to another. Instead, they would prefer to be alerted after the fact. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref AutoReturnCheckedOutItems 4) Check an item out to a patron 5) Check the same item out to another patron 6) Note you are not prompted to confirm the checkout, but are instead alerted that is had been checked out to another patron! Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 87303 [details] [review] Bug 17171: (QA Followup) Add message to batch checkout template Signed-off-by: Liz Rea <wizzyrea@gmail.com> Created attachment 87304 [details] [review] Bug 17171: (QA Follow up) Using patron-title.inc for names Signed-off-by: Liz Rea <wizzyrea@gmail.com> Just noting that I resolved a small conflict in the tests (they still pass) and added a follow up to address Jonathan's use patron-title.inc request. Created attachment 87742 [details] [review] Bug 17171: Add a syspref to allow currently issued items to be issued to a new patron without staff confirmation Some libraries don't want to force the librarians to manually confirm each checkout when the item is checked out to another. Instead, they would prefer to be alerted after the fact. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable the new syspref AutoReturnCheckedOutItems 4) Check an item out to a patron 5) Check the same item out to another patron 6) Note you are not prompted to confirm the checkout, but are instead alerted that is had been checked out to another patron! Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 87743 [details] [review] Bug 17171: (QA follow-up) Add message to batch checkout template Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 87744 [details] [review] Bug 17171: (QA follow-up) Using patron-title.inc for names Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 87745 [details] [review] Bug 17171: (QA follow-up) Remove cardnumber template variable The INCLUDE already takes care of displaying the cardnumber, the extra variable is not needed. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Fixed commit messages, please spell: (QA follow-up) (or QA tool will complain) :) Awesome work all! Pushed to master for 19.05 Enhancement will not be backported to 18.11.x series. This is bugs is shown as sponsored, but who sponsored it is not shown. |