Description
Liz Rea
2016-09-08 03:30:54 UTC
> * use a virtualshelf/list to provide targets for Batch MARC modification.
We already provide the option do pass the contents of a Cart to batch record deletion. I think it makes sense to do the same with MARC modifications.
(In reply to Owen Leonard from comment #1) > We already provide the option do pass the contents of a Cart to batch record > deletion. I think it makes sense to do the same with MARC modifications. ...and we already have that too. Did not know that until today. Me neither - still desirable to use a list? Might be nice to have a batch of records that are persistent, and to have more than one? A list seems more appropriate, as it may be something that is added to over the course of time, rather than something pulled together as a one off. Speaking as more of a librarian than a tech my first instinct was to create a list of things to batch modify. Never thought to put it in a cart. Created attachment 58875 [details] [review] Bug 17273: Add records to modify via shelf or search This patch adds two new ways to add records via two new URL parameters: [1] from_shelf allows you to pass a list number, [2] from_search allows you to pass a search expression. They are added now in the same way as bib_list was done earlier. A future report should incorporate them into the interface. Adding a new method to Virtualshelf along the way. Unit test in followup. Note: I copied the sub _extract_biblionumbers from a new report still in progress. I will move the sub to a module on a new report. Test plan: [1] Pick a list number (you should be allowed to see). And try this URL: /cgi-bin/koha/tools/batch_record_modification.pl?op=list&from_shelf=XX where XX obviously is your list number. [2] Pick a search expression that does not generate too much records. And similarly try: /cgi-bin/koha/tools/batch_record_modification.pl?op=list&from_search=XX Created attachment 58876 [details] [review] Bug 17273: Add tests for Virtualshelf->list_biblionumbers Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 58877 [details] [review] Bug 17273: Add records to modify via shelf or search This patch adds two new ways to add records via two new URL parameters: [1] from_shelf allows you to pass a list number, [2] from_search allows you to pass a search expression. They are added now in the same way as bib_list was done earlier. A future report should incorporate them into the interface. Adding a new method to Virtualshelf along the way. Unit test in followup. Note: I copied the sub _extract_biblionumbers from a new report still in progress. I will move the sub to a module on a new report. Test plan: [1] Pick a list number (you should be allowed to see). And try this URL: /cgi-bin/koha/tools/batch_record_modification.pl?op=list&from_shelf=XX where XX obviously is your list number. [2] Pick a search expression that does not generate too much records. And similarly try: /cgi-bin/koha/tools/batch_record_modification.pl?op=list&from_search=XX Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 58878 [details] [review] Bug 17273: Add tests for Virtualshelf->list_biblionumbers Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 58911 [details] [review] [SIGNED-OFF] Bug 17273: Add records to modify via shelf or search This patch adds two new ways to add records via two new URL parameters: [1] from_shelf allows you to pass a list number, [2] from_search allows you to pass a search expression. They are added now in the same way as bib_list was done earlier. A future report should incorporate them into the interface. Adding a new method to Virtualshelf along the way. Unit test in followup. Note: I copied the sub _extract_biblionumbers from a new report still in progress. I will move the sub to a module on a new report. Test plan: [1] Pick a list number (you should be allowed to see). And try this URL: /cgi-bin/koha/tools/batch_record_modification.pl?op=list&from_shelf=XX where XX obviously is your list number. [2] Pick a search expression that does not generate too much records. And similarly try: /cgi-bin/koha/tools/batch_record_modification.pl?op=list&from_search=XX Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 58912 [details] [review] [SIGNED-OFF] Bug 17273: Add tests for Virtualshelf->list_biblionumbers Test plan: Run t/db_dependent/Virtualshelves.t Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> (In reply to Josef Moravec from comment #10) > Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Thanks Josef! I do not understand the point of this feature as it. You added it but it's not usable from the interface. I do not think it's a good idea to split stuffs like that, let's push it when it's ready. FYI, the bib_list parameter is already added to the interface. From the cart, there are 2 links "Batch modify" and "Batch delete". (In reply to Jonathan Druart from comment #12) > I do not understand the point of this feature as it. You added it but it's > not usable from the interface. > I do not think it's a good idea to split stuffs like that, let's push it > when it's ready. > > FYI, the bib_list parameter is already added to the interface. From the > cart, there are 2 links "Batch modify" and "Batch delete". OK I did not see the link from the cart right away. Would you object to doing those interface things in two new reports? (In reply to Marcel de Rooy from comment #13) > Would you object to doing those interface things in two new reports? Nope but I would not suggest to push them separately. list_biblionumbers c/should call ->get_column from Koha::Objects Hope I don't forget :) This sounds like a duplicate of bug 12759. *** This bug has been marked as a duplicate of bug 12759 *** |