Bug 17273 - Batch MARC Modification - improve options to define which records to modify
Summary: Batch MARC Modification - improve options to define which records to modify
Status: RESOLVED DUPLICATE of bug 12759
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Marcel de Rooy
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 17892
  Show dependency treegraph
 
Reported: 2016-09-08 03:30 UTC by Liz Rea
Modified: 2018-07-02 11:46 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 17273: Add records to modify via shelf or search (4.70 KB, patch)
2017-01-12 14:29 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 17273: Add tests for Virtualshelf->list_biblionumbers (1.58 KB, patch)
2017-01-12 14:29 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 17273: Add records to modify via shelf or search (4.75 KB, patch)
2017-01-12 14:31 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 17273: Add tests for Virtualshelf->list_biblionumbers (1.58 KB, patch)
2017-01-12 14:31 UTC, Marcel de Rooy
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 17273: Add records to modify via shelf or search (4.78 KB, patch)
2017-01-13 06:48 UTC, Josef Moravec
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 17273: Add tests for Virtualshelf->list_biblionumbers (1.61 KB, patch)
2017-01-13 06:48 UTC, Josef Moravec
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Liz Rea 2016-09-08 03:30:54 UTC
Basically, duplicate the same thing we have for patrons bulk modification (create a patron list, use that list in the batch mod tool), but for biblios. 

Users should be able to do the following with this enhancement:

* use a virtualshelf/list to provide targets for Batch MARC modification.

Additionally, or alternatively, we could provide a "download file of biblionumbers" from a search result page that could then be imported into the tool using existing workflow of "Use a file."

It could also be "download file of biblionumbers for selected results."

Personally I think a list is a better choice, but don't want to be limiting in what the solution is. I do know that the workflow as it stands is pretty awkward.
Comment 1 Owen Leonard 2016-09-08 13:39:05 UTC
> * use a virtualshelf/list to provide targets for Batch MARC modification.

We already provide the option do pass the contents of a Cart to batch record deletion. I think it makes sense to do the same with MARC modifications.
Comment 2 Owen Leonard 2016-09-08 14:40:39 UTC
(In reply to Owen Leonard from comment #1)

> We already provide the option do pass the contents of a Cart to batch record
> deletion. I think it makes sense to do the same with MARC modifications.

...and we already have that too. Did not know that until today.
Comment 3 Liz Rea 2016-09-08 22:03:48 UTC
Me neither - still desirable to use a list? Might be nice to have a batch of records that are persistent, and to have more than one?
Comment 4 Elaine Bradtke 2016-11-07 18:52:04 UTC
A list seems more appropriate, as it may be something that is added to over the course of time, rather than something pulled together as a one off. Speaking as more of a librarian than a tech my first instinct was to create a list of things to batch modify.  Never thought to put it in a cart.
Comment 5 Marcel de Rooy 2017-01-12 14:29:12 UTC Comment hidden (obsolete)
Comment 6 Marcel de Rooy 2017-01-12 14:29:33 UTC Comment hidden (obsolete)
Comment 7 Marcel de Rooy 2017-01-12 14:31:01 UTC
Created attachment 58877 [details] [review]
Bug 17273: Add records to modify via shelf or search

This patch adds two new ways to add records via two new URL parameters:
[1] from_shelf allows you to pass a list number,
[2] from_search allows you to pass a search expression.
They are added now in the same way as bib_list was done earlier. A future
report should incorporate them into the interface.

Adding a new method to Virtualshelf along the way. Unit test in followup.

Note: I copied the sub _extract_biblionumbers from a new report still in
progress. I will move the sub to a module on a new report.

Test plan:
[1] Pick a list number (you should be allowed to see). And try this URL:
    /cgi-bin/koha/tools/batch_record_modification.pl?op=list&from_shelf=XX
    where XX obviously is your list number.
[2] Pick a search expression that does not generate too much records.
    And similarly try:
    /cgi-bin/koha/tools/batch_record_modification.pl?op=list&from_search=XX

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 8 Marcel de Rooy 2017-01-12 14:31:05 UTC
Created attachment 58878 [details] [review]
Bug 17273: Add tests for Virtualshelf->list_biblionumbers

Test plan:
Run t/db_dependent/Virtualshelves.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 9 Josef Moravec 2017-01-13 06:48:21 UTC
Created attachment 58911 [details] [review]
[SIGNED-OFF] Bug 17273: Add records to modify via shelf or search

This patch adds two new ways to add records via two new URL parameters:
[1] from_shelf allows you to pass a list number,
[2] from_search allows you to pass a search expression.
They are added now in the same way as bib_list was done earlier. A future
report should incorporate them into the interface.

Adding a new method to Virtualshelf along the way. Unit test in followup.

Note: I copied the sub _extract_biblionumbers from a new report still in
progress. I will move the sub to a module on a new report.

Test plan:
[1] Pick a list number (you should be allowed to see). And try this URL:
    /cgi-bin/koha/tools/batch_record_modification.pl?op=list&from_shelf=XX
    where XX obviously is your list number.
[2] Pick a search expression that does not generate too much records.
    And similarly try:
    /cgi-bin/koha/tools/batch_record_modification.pl?op=list&from_search=XX

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 10 Josef Moravec 2017-01-13 06:48:26 UTC
Created attachment 58912 [details] [review]
[SIGNED-OFF] Bug 17273: Add tests for Virtualshelf->list_biblionumbers

Test plan:
Run t/db_dependent/Virtualshelves.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 11 Marcel de Rooy 2017-01-13 07:01:16 UTC
(In reply to Josef Moravec from comment #10)
> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Thanks Josef!
Comment 12 Jonathan Druart 2017-01-17 08:38:15 UTC
I do not understand the point of this feature as it. You added it but it's not usable from the interface.
I do not think it's a good idea to split stuffs like that, let's push it when it's ready.

FYI, the bib_list parameter is already added to the interface. From the cart, there are 2 links "Batch modify" and "Batch delete".
Comment 13 Marcel de Rooy 2017-01-17 12:57:36 UTC
(In reply to Jonathan Druart from comment #12)
> I do not understand the point of this feature as it. You added it but it's
> not usable from the interface.
> I do not think it's a good idea to split stuffs like that, let's push it
> when it's ready.
> 
> FYI, the bib_list parameter is already added to the interface. From the
> cart, there are 2 links "Batch modify" and "Batch delete".

OK I did not see the link from the cart right away.
Would you object to doing those interface things in two new reports?
Comment 14 Jonathan Druart 2017-01-17 13:21:32 UTC
(In reply to Marcel de Rooy from comment #13)
> Would you object to doing those interface things in two new reports?

Nope but I would not suggest to push them separately.
Comment 15 Marcel de Rooy 2017-01-17 13:28:36 UTC
list_biblionumbers c/should call ->get_column from Koha::Objects
Comment 16 Marcel de Rooy 2017-01-17 13:29:18 UTC
Hope I don't forget :)
Comment 17 Jonathan Druart 2018-05-30 17:02:17 UTC
This sounds like a duplicate of bug 12759.
Comment 18 Marcel de Rooy 2018-07-02 11:46:49 UTC

*** This bug has been marked as a duplicate of bug 12759 ***