Bug 17285

Summary: Rancor - Advanced editor fails or broken
Product: Koha Reporter: Héctor Eduardo Castro Avalos <hector.hecaxmmx>
Component: CatalogingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: major    
Priority: P5 - low CC: kyle, m.de.rooy, nick
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 15758    
Bug Blocks:    
Attachments: Bug 17285: (15758 follow-up) Fix advanced editor
[SIGNED-OFF]Bug 17285: (15758 follow-up) Fix advanced editor
Bug 17285: (15758 follow-up) Fix advanced editor

Description Héctor Eduardo Castro Avalos 2016-09-09 18:11:27 UTC
When you try to create or modify a record with the "Advanced editor", the screen is forzen in the message "Loading, please wait"

IRC Comment with oleonard:

>"git bisect says the cause is Bug 15758"
>"Specifically, commit df97814"
Comment 1 Owen Leonard 2016-09-09 18:14:34 UTC
> >"git bisect says the cause is Bug 15758"
> >"Specifically, commit df97814"

The error is in svc/cataloguing/framework?callback=define
Comment 2 Jonathan Druart 2016-09-12 15:48:22 UTC Comment hidden (obsolete)
Comment 3 Héctor Eduardo Castro Avalos 2016-09-12 16:08:12 UTC Comment hidden (obsolete)
Comment 4 Nick Clemens 2016-09-12 16:18:53 UTC
Created attachment 55510 [details] [review]
Bug 17285: (15758 follow-up) Fix advanced editor

Little mistake from df97814, $branches is a hash { branchcode =>
branchname }

Test plan:
Edit a biblio with the advanced editor

Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
The advanced editor works as expected

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 5 Kyle M Hall 2016-09-12 16:33:31 UTC
Pushed to master for 16.11, thanks Jonathan!