| Summary: | api_secret_passphrase missing in packages setup | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Component: | Web services | Assignee: | Tomás Cohen Arazi (tcohen) <tomascohen> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | chris, josef.moravec, julian.maurice, kyle.m.hall, kyle, martin.renvoize |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28911 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 13799, 17332 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 17336: Add api_secret_passphrase entry in packages setup
Bug 17336: Add api_secret_passphrase entry in packages setup Bug 17336: Add api_secret_passphrase entry in packages setup |
||
|
Description
Tomás Cohen Arazi (tcohen)
2016-09-23 14:54:00 UTC
Created attachment 55778 [details] [review] Bug 17336: Add api_secret_passphrase entry in packages setup Bug 13799 introduced the api_secret_passphrase on source installs, but missed to do so on packages. This patch introduces the entry on the template koha-conf-site.xml.in file, and patches koha-create so it generates a randomized string (64 chars) to put in it. To test: - Apply the patch - Grab the new template file: $ sudo cp kohaclone/debian/templates/koha-conf-site.xml.in \ /etc/koha - Create a new instance: $ kohaclone/debian/scripts/koha-create --create-db blah => SUCCESS: The script runs fine, /etc/koha/sites/blah/koha-conf.xml contains the api_secret_passphrase entry. - Sign off :-D Applying: Bug 17336: Add api_secret_passphrase entry in packages setup fatal: sha1 information is lacking or useless (debian/templates/koha-conf-site.xml.in). error: could not build fake ancestor Patch failed at 0001 Bug 17336: Add api_secret_passphrase entry in packages setup Sorry, forgot I wrote it on top of 17332 Created attachment 55818 [details] [review] Bug 17336: Add api_secret_passphrase entry in packages setup Bug 13799 introduced the api_secret_passphrase on source installs, but missed to do so on packages. This patch introduces the entry on the template koha-conf-site.xml.in file, and patches koha-create so it generates a randomized string (64 chars) to put in it. To test: - Apply the patch - Grab the new template file: $ sudo cp kohaclone/debian/templates/koha-conf-site.xml.in \ /etc/koha - Create a new instance: $ kohaclone/debian/scripts/koha-create --create-db blah => SUCCESS: The script runs fine, /etc/koha/sites/blah/koha-conf.xml contains the api_secret_passphrase entry. - Sign off :-D Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 55830 [details] [review] Bug 17336: Add api_secret_passphrase entry in packages setup Bug 13799 introduced the api_secret_passphrase on source installs, but missed to do so on packages. This patch introduces the entry on the template koha-conf-site.xml.in file, and patches koha-create so it generates a randomized string (64 chars) to put in it. To test: - Apply the patch - Grab the new template file: $ sudo cp kohaclone/debian/templates/koha-conf-site.xml.in \ /etc/koha - Create a new instance: $ kohaclone/debian/scripts/koha-create --create-db blah => SUCCESS: The script runs fine, /etc/koha/sites/blah/koha-conf.xml contains the api_secret_passphrase entry. - Sign off :-D Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 16.11, thanks Tomas! |