Bug 24151 added a way to pseudonymize patron transactions. It added a new config to koha-conf <bcrypt_settings> This is added for new installs, but not for upgraded sites, and there are no instructions on the syspref or elsewhere for adding To recreate: 1 - Spin up a 20.05 (checkout 20.05.x and reset_all in kohadevbox) 2 - Upgrade to master (checkout master, updatedatabase) 3 - Enable pseudonymization 4 - Attempt a checkout 5 - boom you can manually add the settings by running the command below: htpasswd -bnBC 10 "" password | tr -d ':\n' | sed 's/$2y/$2a/' And pasting the results into <bcrypt_settings> in the config
Mason, is it something we could do?
See also 1. commit 242722e99df77be9ce0e4c6d52ff402e0a77d604 Bug 17336: Add api_secret_passphrase entry in packages setup and 2. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28998#c6
Just got stung by this one. There are quite a few settings like this I think (e.g. plugin_repos, koha_xslt_security, smtp_server).
(In reply to David Cook from comment #3) > Just got stung by this one. > > There are quite a few settings like this I think (e.g. plugin_repos, > koha_xslt_security, smtp_server). I'm writing a local script that fixes up a lot of the missing/bad config. It's not very elegant but I could probably share it once I'm done.
(In reply to David Cook from comment #4) > (In reply to David Cook from comment #3) > > Just got stung by this one. > > > > There are quite a few settings like this I think (e.g. plugin_repos, > > koha_xslt_security, smtp_server). > > I'm writing a local script that fixes up a lot of the missing/bad config. > It's not very elegant but I could probably share it once I'm done. Basically, I loop through /etc/koha/sites, check each koha-conf.xml, and then re-write it. It does pretty well overall. The output of XML::LibXML is quite similar to /etc/koha/koha-conf-site.xml.in. The main difference is a bit of whitespace and self-closing tags in some of the Zebra-specific configuration within <yazgfs>. Zebra seems fine with empty tags and different whitespace, so I'm fairly content. Half-tempted to submit a patch to make the whitespace for /etc/koha/koha-conf-site.xml.in be more in line with the output of XML::LibXML, but I don't know what folk would think of that...
(In reply to David Cook from comment #4) > (In reply to David Cook from comment #3) > > Just got stung by this one. > > > > There are quite a few settings like this I think (e.g. plugin_repos, > > koha_xslt_security, smtp_server). > > I'm writing a local script that fixes up a lot of the missing/bad config. > It's not very elegant but I could probably share it once I'm done. Yes please, share it.
Created attachment 144373 [details] Example script for koha-conf.xml fixup This is a script I did that uses a reference koha-conf.xml to update some configuration, or just generates missing config (like bcrypt_settings - including comments) -- I don't think it's particularly robust, so I wouldn't rely on it. I wrote it for a once-off point in time update. But maybe it could inspire someone to write a koha-conf.xml upgrade tool. That said, I don't love the idea of automatically upgrading koha-conf.xml. It seems a bit dangerous. Although if a backup mechanism is used (like in my script), then I suppose risk is less as you can always fall back.