Summary: | Add system preference SCOMainUserBlock | ||
---|---|---|---|
Product: | Koha | Reporter: | Marc Véron <veron> |
Component: | Self checkout | Assignee: | Marc Véron <veron> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | arm, katrin.fischer, nick |
Version: | master | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5250 | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 12691 | ||
Bug Blocks: | |||
Attachments: |
Bug 17381: Add system preference SCOMainUserBlock
[SIGNED-OFF] Bug 17381: Add system preference SCOMainUserBlock Bug 17381: Add system preference SCOMainUserBlock [SIGNED-OFF] Bug 17381: Add system preference SCOMainUserBlock Bug 17381: Add system preference SCOMainUserBlock |
Description
Marc Véron
2016-09-30 06:36:37 UTC
I would love this - just setting up SCO and noted the need for a bit more on screen help. I would love this option! Just setting up SCO and noted the need for a bit more user interface on screen help. It could be Library specific, so an HTML section would be very useful. I have help until end March 2017 - if anyone has time to introduce him to the code used we might be able to contribute, or to test. I would also like to change the text of the Print prompt - Cancel or OK is not very helpful in answer to "Do you want to print?" Hi Agnes, maybe sent them to the IRC chat - there is almost always someone around to help out and answer questions. For a development setup, you can point them to https://github.com/digibib/kohadevbox. For other information on the development process the wiki is a helpful resource, especially the pages linked to the Developer handbook: https://wiki.koha-community.org/wiki/Developer_handbook. Good luck! Created attachment 62295 [details] [review] Bug 17381: Add system preference SCOMainUserBlock This patch adds a system preference SCOMainUserBlock to display custom HTML on the self checkout page. To test: - Set up self checkout (see section Self Checkout in Circulaton sysprefs ) - Apply patch - Update db - Add some HTML system preference SCOMainUserBlock - Go to sco page - Verify that HTML displays on page (logged in and not logged in) Still applies on current master Created attachment 63611 [details] [review] [SIGNED-OFF] Bug 17381: Add system preference SCOMainUserBlock This patch adds a system preference SCOMainUserBlock to display custom HTML on the self checkout page. To test: - Set up self checkout (see section Self Checkout in Circulaton sysprefs ) - Apply patch - Update db - Add some HTML system preference SCOMainUserBlock - Go to sco page - Verify that HTML displays on page (logged in and not logged in) Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Hi Marc, 1 - I am not sure where that closing div goes - #newcheckout does seem to close properly unless I missed something 2 - Why not use Koha.Preference TT plugin instead of passing the pref? -Nick Hi Nick I have no time ATM - If you like feel free to provide a follow-up. Marc I was not aware of Bug 12691 - Use Koha.Preference for calls to SCOUserJS, SCOUserCSS, OPACUserCSS, opacuserjs, etc in Self-Checkout Will re-write that 17381 on top of 12691. Created attachment 66271 [details] [review] Bug 17381: Add system preference SCOMainUserBlock This patch adds a system preference SCOMainUserBlock to display custom HTML on the self checkout page. To test: - Set up self checkout (see section Self Checkout in Circulaton sysprefs ) - Apply patch - Update db - Add some HTML system preference SCOMainUserBlock - Go to sco page - Verify that HTML displays on page (logged in and not logged in) New version based on Koha.Preference TT plugin as of comment #7 Depends on Bug 12691 Created attachment 66322 [details] [review] [SIGNED-OFF] Bug 17381: Add system preference SCOMainUserBlock This patch adds a system preference SCOMainUserBlock to display custom HTML on the self checkout page. To test: - Set up self checkout (see section Self Checkout in Circulaton sysprefs ) - Apply patch - Update db - Add some HTML system preference SCOMainUserBlock - Go to sco page - Verify that HTML displays on page (logged in and not logged in) New version based on Koha.Preference TT plugin as of comment #7 Depends on Bug 12691 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 68481 [details] [review] Bug 17381: Add system preference SCOMainUserBlock This patch adds a system preference SCOMainUserBlock to display custom HTML on the self checkout page. To test: - Set up self checkout (see section Self Checkout in Circulaton sysprefs ) - Apply patch - Update db - Add some HTML system preference SCOMainUserBlock - Go to sco page - Verify that HTML displays on page (logged in and not logged in) New version based on Koha.Preference TT plugin as of comment #7 Depends on Bug 12691 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 17.11, thanks to everybody involved! Thank you everyone! |