Summary: | Exporting framework always export the default framework | ||
---|---|---|---|
Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
Component: | System Administration | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | brendan, f.demians, gmcharlt, hagud, hector.hecaxmmx, julian.maurice |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 16035 | ||
Bug Blocks: | |||
Attachments: |
Bug 17389: (bug 16035 follow-up) Fix export non-default frameworks
Bug 17389: Clear logs [SIGNED-OFF]Bug 17389: (bug 16035 follow-up) Fix export non-default frameworks [SIGNED-OFF]Bug 17389: Clear logs [PASSED QA] Bug 17389: (bug 16035 follow-up) Fix export non-default frameworks [PASSED QA] Bug 17389: Clear logs |
Description
Jonathan Druart
2016-10-03 14:14:09 UTC
From: commit 705097f938ba9334c21b3e6f006bd7c9ba38763c Bug 16035: MARC default bibliographic framework Export fix Created attachment 55975 [details] [review] Bug 17389: (bug 16035 follow-up) Fix export non-default frameworks Trivial patch, no need to explain anything :) Test plan: Export default framework Export other frameworks => The frameworkcode column should contain the framework code Created attachment 55977 [details] [review] Bug 17389: Clear logs Logs are full of: Use of uninitialized value in substitution (s///) at C4/ImportExportFramework.pm line 282. Use of uninitialized value in concatenation (.) or string at C4/ImportExportFramework.pm line 283. Some field are NULL in DB, we need to init the value to an empty string to avoid these warnings. Note: This fix is not related to the original bug Created attachment 55983 [details] [review] [SIGNED-OFF]Bug 17389: (bug 16035 follow-up) Fix export non-default frameworks Trivial patch, no need to explain anything :) Test plan: Export default framework Export other frameworks => The frameworkcode column should contain the framework code Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Created attachment 55984 [details] [review] [SIGNED-OFF]Bug 17389: Clear logs Logs are full of: Use of uninitialized value in substitution (s///) at C4/ImportExportFramework.pm line 282. Use of uninitialized value in concatenation (.) or string at C4/ImportExportFramework.pm line 283. Some field are NULL in DB, we need to init the value to an empty string to avoid these warnings. Note: This fix is not related to the original bug Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Warnings avoided Created attachment 56153 [details] [review] [PASSED QA] Bug 17389: (bug 16035 follow-up) Fix export non-default frameworks Trivial patch, no need to explain anything :) Test plan: Export default framework Export other frameworks => The frameworkcode column should contain the framework code Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Created attachment 56154 [details] [review] [PASSED QA] Bug 17389: Clear logs Logs are full of: Use of uninitialized value in substitution (s///) at C4/ImportExportFramework.pm line 282. Use of uninitialized value in concatenation (.) or string at C4/ImportExportFramework.pm line 283. Some field are NULL in DB, we need to init the value to an empty string to avoid these warnings. Note: This fix is not related to the original bug Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Warnings avoided Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to Master - Should be in the November 16.11 Release. Thanks! Pushed in 16.05. Will be in 16.05.05. Pushed to 3.22.x, will be in 3.22.12 *** Bug 17410 has been marked as a duplicate of this bug. *** |