Summary: | Datepicker on checkout fails when dateformat = iso | ||
---|---|---|---|
Product: | Koha | Reporter: | Magnus Enger <magnus> |
Component: | Circulation | Assignee: | Jonathan Druart <jonathan.druart> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | f.demians, gmcharlt, kyle.m.hall, kyle, mtj, mtompset, nick |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | 14060 | ||
Bug Blocks: | |||
Attachments: |
Bug 17524: Fix datepicker check for iso dates
Bug 17524: Fix datepicker check for iso dates Bug 17524: Fix datepicker check for iso dates |
Description
Magnus Enger
2016-10-31 14:40:23 UTC
Created attachment 57001 [details] [review] Bug 17524: Fix datepicker check for iso dates Iso dates are yyyy-mm-dd, the is_valid JS function expects \d{2}-\d{2}-\d{4} when it should be \d{4}-\d{2}-\d{2} Test plan: Switch DateFormat to iso Set a due date using the datepicker => Should work as expected This should be backported ASAP, please test & QA quickly. I have applied the fix to a live server and it works, I'll do a signoff later today if noone beats me to it. Thanks for a very quick fix, Jonathan! (In reply to Nick Clemens from comment #1) > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 ? Created attachment 57006 [details] [review] Bug 17524: Fix datepicker check for iso dates Iso dates are yyyy-mm-dd, the is_valid JS function expects \d{2}-\d{2}-\d{4} when it should be \d{4}-\d{2}-\d{2} Test plan: Switch DateFormat to iso Set a due date using the datepicker => Should work as expected Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Created attachment 57007 [details] [review] Bug 17524: Fix datepicker check for iso dates Iso dates are yyyy-mm-dd, the is_valid JS function expects \d{2}-\d{2}-\d{4} when it should be \d{4}-\d{2}-\d{2} Test plan: Switch DateFormat to iso Set a due date using the datepicker => Should work as expected Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> P.S. This is bigger than just checkout. Member birth dates, for example. Pushed to master for 16.11, thanks Jonathan! Pushed in 16.05. Will be in 16.05.06. |