This surfaced after upgrading to 16.05.05. To reproduce: - Make sure dateformat = iso - Go to the checkout screen for some patron - Click on "Checkout settings" - Try to pick a date from the calendar -> nothing happens - Try to enter an iso date -> you get a js popup saying "Please enter a valid date (should match yyyy-mm-dd)"
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876
Created attachment 57001 [details] [review] Bug 17524: Fix datepicker check for iso dates Iso dates are yyyy-mm-dd, the is_valid JS function expects \d{2}-\d{2}-\d{4} when it should be \d{4}-\d{2}-\d{2} Test plan: Switch DateFormat to iso Set a due date using the datepicker => Should work as expected
Caused by bug 14060
This should be backported ASAP, please test & QA quickly.
I have applied the fix to a live server and it works, I'll do a signoff later today if noone beats me to it. Thanks for a very quick fix, Jonathan!
(In reply to Nick Clemens from comment #1) > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14876 ?
Created attachment 57006 [details] [review] Bug 17524: Fix datepicker check for iso dates Iso dates are yyyy-mm-dd, the is_valid JS function expects \d{2}-\d{2}-\d{4} when it should be \d{4}-\d{2}-\d{2} Test plan: Switch DateFormat to iso Set a due date using the datepicker => Should work as expected Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 57007 [details] [review] Bug 17524: Fix datepicker check for iso dates Iso dates are yyyy-mm-dd, the is_valid JS function expects \d{2}-\d{2}-\d{4} when it should be \d{4}-\d{2}-\d{2} Test plan: Switch DateFormat to iso Set a due date using the datepicker => Should work as expected Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
P.S. This is bigger than just checkout. Member birth dates, for example.
Pushed to master for 16.11, thanks Jonathan!
Pushed in 16.05. Will be in 16.05.06.