Bug 17584

Summary: Add the Koha::Patron->checkouts method
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: katrin.fischer, kyle, m.de.rooy, nick, tomascohen
Version: Main   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19830
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 17580, 17796    
Bug Blocks: 17588    
Attachments: Bug 17584: Add the Koha::Patron->get_issues method
[SIGNED-OFF] Bug 17584: Add the Koha::Patron->get_issues method
Bug 17584: Add the Koha::Patron->get_issues method
Bug 17584: Add the Koha::Patron->get_checkouts method
Bug 17584: Add the Koha::Patron->get_checkouts method
Bug 17584 [QA Followup] - Rename Koha::Patron::get_checkouts to Koha::Patron::checkouts

Description Jonathan Druart 2016-11-08 15:19:38 UTC

    
Comment 1 Jonathan Druart 2016-11-08 15:22:57 UTC
Created attachment 57331 [details] [review]
Bug 17584: Add the Koha::Patron->get_issues method

Test plan:
  prove t/db_dependent/Koha/Patrons.t
should return green
Comment 2 Josef Moravec 2016-11-09 10:10:31 UTC
Created attachment 57365 [details] [review]
[SIGNED-OFF] Bug 17584: Add the Koha::Patron->get_issues method

Test plan:
  prove t/db_dependent/Koha/Patrons.t
should return green

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 3 Marcel de Rooy 2016-12-02 08:06:22 UTC
Depends on a PNA
Comment 4 Nick Clemens 2016-12-05 15:19:10 UTC
Applying: Bug 17584: Add the Koha::Patron->get_issues method
fatal: sha1 information is lacking or useless (Koha/Patron.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 17584: Add the Koha::Patron->get_issues method
Comment 5 Jonathan Druart 2016-12-05 15:33:27 UTC
Created attachment 57971 [details] [review]
Bug 17584: Add the Koha::Patron->get_issues method

Test plan:
  prove t/db_dependent/Koha/Patrons.t
should return green

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 6 Jonathan Druart 2016-12-20 14:02:07 UTC
Created attachment 58295 [details] [review]
Bug 17584: Add the Koha::Patron->get_checkouts method

Test plan:
  prove t/db_dependent/Koha/Patrons.t
should return green

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 7 Jonathan Druart 2016-12-20 14:02:34 UTC
Rebased on top of bug 17796 (Move Koha::Issues to Koha::Checkouts)
Comment 8 Kyle M Hall 2016-12-23 14:14:03 UTC
Created attachment 58419 [details] [review]
Bug 17584: Add the Koha::Patron->get_checkouts method

Test plan:
  prove t/db_dependent/Koha/Patrons.t
should return green

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 9 Kyle M Hall 2016-12-23 14:14:11 UTC
Created attachment 58420 [details] [review]
Bug 17584 [QA Followup] - Rename Koha::Patron::get_checkouts to Koha::Patron::checkouts

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 10 Kyle M Hall 2016-12-28 13:51:08 UTC
Pushed to master for 17.05, thanks Jonathan!
Comment 11 Katrin Fischer 2017-01-04 21:45:57 UTC
This won't get ported back to 16.11.x as it is an enhancement.