| Summary: | Regression: Incomplete CSS update introduced by Bug 14610 | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Owen Leonard <oleonard> |
| Component: | Templates | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | chris.kirby, kyle, mtj |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | String patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 14610 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 17601 - Regression: Incomplete CSS update introduced by Bug 14610
Bug 17601 - Regression: Incomplete CSS update introduced by Bug 14610 Bug 17601 - Regression: Incomplete CSS update introduced by Bug 14610 [PASSED QA] Bug 17601 - Regression: Incomplete CSS update introduced by Bug 14610 |
||
|
Description
Owen Leonard
2016-11-09 18:20:27 UTC
Created attachment 57422 [details] [review] Bug 17601 - Regression: Incomplete CSS update introduced by Bug 14610 Bug 14610 revised staff-global.css so that the "holdcount" class was renamed "number_box." That's good. It's good to have something more generic since the class is used in multiple places. The problem is that there are still several instances of the "holdcount" class in the templates which should have been updated at the same time to say "number_box." Those instances are now unstyled. Test Plan: 1) Apply this patch 2) Check that the holds count on catalogue/detail.pl is styled 3) Check that the patron modifications count on members/member.pl is styled 4) Check that the pending comments count on tools/tools-home.pl is styled 5) Check that the pending tags count on tools/tools-home.pl is styled So far, I am finding that the templates have indeed updated so that the "holdcount" class has been replaced by "number_box." But pending comments count on tools/tools-home.pl and also (the other instances) does have a border around the number or a background-color, whereas "holdcount" did. Is this what is expected? (In reply to Chris Kirby from comment #2) > So far, I am finding that the templates have indeed updated so that the > "holdcount" class has been replaced by "number_box." But pending comments > count on tools/tools-home.pl (and also the other instances) does have a > border around the number or a background-color, whereas "holdcount" did. Is > this what is expected? 1)Applied patch in this patch in a sandbox (http://pro.user10-koha.sandbox.biblibre.eu/). I also tested the existing behavior on master in (http://pro.user09-koha.sandbox.biblibre.eu/). Created a hold on an item, signed into the OPAC as a patron and modified patron information; in the OPAC added a tag to a title. in the OPAC, added a comment to a title. In the staff client, I checked the following: 2)Checked that the holds count on catalogue/detail.pl. It has been renamed "number_box" but does not appear to be styled. 3) Check that the patron modifications count on members/member.pl. It has been renamed "number_box" but does not appear to be styled. 4) Check that the pending comments count on tools/tools-home.pl. It has been renamed "number_box" but does not appear to be styled. 5) Check that the pending tags count on tools/tools-home.pl. It has been renamed "number_box" but does not appear to be styled. Created attachment 57466 [details] [review] Bug 17601 - Regression: Incomplete CSS update introduced by Bug 14610 Bug 14610 revised staff-global.css so that the "holdcount" class was renamed "number_box." That's good. It's good to have something more generic since the class is used in multiple places. The problem is that there are still several instances of the "holdcount" class in the templates which should have been updated at the same time to say "number_box." Those instances are now unstyled. Test Plan: 1) Apply this patch 2) Check that the holds count on catalogue/detail.pl is styled 3) Check that the patron modifications count on members/member.pl is styled 4) Check that the pending comments count on tools/tools-home.pl is styled 5) Check that the pending tags count on tools/tools-home.pl is styled Signed-off-by: Chris Kirby <christopherlawrencekirby@gmail.com> Signed off (comment 5) after applying patch to my local development environment and observing the expected styling. Created attachment 57611 [details] [review] Bug 17601 - Regression: Incomplete CSS update introduced by Bug 14610 Bug 14610 revised staff-global.css so that the "holdcount" class was renamed "number_box." That's good. It's good to have something more generic since the class is used in multiple places. The problem is that there are still several instances of the "holdcount" class in the templates which should have been updated at the same time to say "number_box." Those instances are now unstyled. Test Plan: 1) Apply this patch 2) Check that the holds count on catalogue/detail.pl is styled 3) Check that the patron modifications count on members/member.pl is styled 4) Check that the pending comments count on tools/tools-home.pl is styled 5) Check that the pending tags count on tools/tools-home.pl is styled Signed-off-by: Chris Kirby <christopherlawrencekirby@gmail.com> Created attachment 57612 [details] [review] [PASSED QA] Bug 17601 - Regression: Incomplete CSS update introduced by Bug 14610 Bug 14610 revised staff-global.css so that the "holdcount" class was renamed "number_box." That's good. It's good to have something more generic since the class is used in multiple places. The problem is that there are still several instances of the "holdcount" class in the templates which should have been updated at the same time to say "number_box." Those instances are now unstyled. Test Plan: 1) Apply this patch 2) Check that the holds count on catalogue/detail.pl is styled 3) Check that the patron modifications count on members/member.pl is styled 4) Check that the pending comments count on tools/tools-home.pl is styled 5) Check that the pending tags count on tools/tools-home.pl is styled Signed-off-by: Chris Kirby <christopherlawrencekirby@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Pushed to master for 16.11! Blocked by new feature, skipping for 16.05.x |