Summary: | Add the ability of sending a confirmation e-mail to patron when hold is placed | ||
---|---|---|---|
Product: | Koha | Reporter: | Sally <sally.healey> |
Component: | Hold requests | Assignee: | Aleisha Amohia <aleisha> |
Status: | RESOLVED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | aleisha, caroline.cyr-la-rose, fridolin.somers, gmcharlt, josef.moravec, kelly, koha, m.de.rooy, marjorie.barry-vila, sally.healey, tomascohen |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Caroline Cyr La Rose | Documentation submission: | https://gitlab.com/koha-community/koha-manual/-/merge_requests/926 |
Text to go in the release notes: |
When the new system preference `EmailPatronWhenHoldIsPlaced` is activated, a notice will be sent to the patron to confirm their hold has been placed. The notice template used is HOLDPLACED_PATRON.
|
Version(s) released in: |
23.11.00
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 37436 | ||
Attachments: |
Bug 17617: EmailPatronWhenHoldIsPlaced system preference
Bug 17617: Add HOLDPLACED_PATRON notice Bug 17617: Unit tests Bug 17617: Confirmation email to patron when hold is placed Bug 17617: EmailPatronWhenHoldIsPlaced system preference Bug 17617: Add HOLDPLACED_PATRON notice Bug 17617: Unit tests Bug 17617: Confirmation email to patron when hold is placed Bug 17617: EmailPatronWhenHoldIsPlaced system preference Bug 17617: Add HOLDPLACED_PATRON notice Bug 17617: Unit tests Bug 17617: Confirmation email to patron when hold is placed |
Description
Sally
2016-11-11 17:43:09 UTC
*** Bug 35140 has been marked as a duplicate of this bug. *** Created attachment 157961 [details] [review] Bug 17617: EmailPatronWhenHoldIsPlaced system preference Created attachment 157962 [details] [review] Bug 17617: Add HOLDPLACED_PATRON notice A HOLDPLACED notice exists and is used by the emailLibrarianWhenHoldIsPlaced function, but libraries may want to use different wording when emailing patrons. Created attachment 157963 [details] [review] Bug 17617: Unit tests Created attachment 157964 [details] [review] Bug 17617: Confirmation email to patron when hold is placed This enhancement adds a new notice HOLDPLACED_PATRON that will be sent to a patron when a hold is placed for them. It depends on the new system preference EmailPatronWhenHoldIsPlaced to be enabled. To test: 1) Update database and restart services 2) Go to Koha Administration -> System preferences and search for the new EmailPatronWhenHoldIsPlaced syspref. It should be disabled by default - leave it disabled for now. 3) Search for a record and go to the Holds tab. Place a hold for your patron. 4) Go to your patron's account and go to the Notices tab. Confirm the HOLDPLACED_PATRON notice was NOT queued. 5) Enable the EmailPatronWhenHoldIsPlaced syspref. 6) Repeat steps 3 and 4. Confirm the HOLDPLACED_PATRON notice WAS generated and queued. 7) Confirm tests pass t/db_dependent/Holds.t Sponsored-by: Fire and Emergency New Zealand Created attachment 157995 [details] [review] Bug 17617: EmailPatronWhenHoldIsPlaced system preference Signed-off-by: Kelly <kelly@bywatersolutions.com> Created attachment 157996 [details] [review] Bug 17617: Add HOLDPLACED_PATRON notice A HOLDPLACED notice exists and is used by the emailLibrarianWhenHoldIsPlaced function, but libraries may want to use different wording when emailing patrons. Signed-off-by: Kelly <kelly@bywatersolutions.com> Created attachment 157997 [details] [review] Bug 17617: Unit tests Signed-off-by: Kelly <kelly@bywatersolutions.com> Created attachment 157998 [details] [review] Bug 17617: Confirmation email to patron when hold is placed This enhancement adds a new notice HOLDPLACED_PATRON that will be sent to a patron when a hold is placed for them. It depends on the new system preference EmailPatronWhenHoldIsPlaced to be enabled. To test: 1) Update database and restart services 2) Go to Koha Administration -> System preferences and search for the new EmailPatronWhenHoldIsPlaced syspref. It should be disabled by default - leave it disabled for now. 3) Search for a record and go to the Holds tab. Place a hold for your patron. 4) Go to your patron's account and go to the Notices tab. Confirm the HOLDPLACED_PATRON notice was NOT queued. 5) Enable the EmailPatronWhenHoldIsPlaced syspref. 6) Repeat steps 3 and 4. Confirm the HOLDPLACED_PATRON notice WAS generated and queued. 7) Confirm tests pass t/db_dependent/Holds.t Sponsored-by: Fire and Emergency New Zealand Signed-off-by: Kelly <kelly@bywatersolutions.com> This is great, Aleisha - appreciate you working on this one. In addition to the system preference: Patrons can control whether they receive a hold collection notice via their messaging preferences. I wonder if they should also be allowed to opt out of these hold placed notices? We could open a new bug for it? Created attachment 158310 [details] [review] Bug 17617: EmailPatronWhenHoldIsPlaced system preference Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 158311 [details] [review] Bug 17617: Add HOLDPLACED_PATRON notice A HOLDPLACED notice exists and is used by the emailLibrarianWhenHoldIsPlaced function, but libraries may want to use different wording when emailing patrons. Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 158312 [details] [review] Bug 17617: Unit tests Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 158313 [details] [review] Bug 17617: Confirmation email to patron when hold is placed This enhancement adds a new notice HOLDPLACED_PATRON that will be sent to a patron when a hold is placed for them. It depends on the new system preference EmailPatronWhenHoldIsPlaced to be enabled. To test: 1) Update database and restart services 2) Go to Koha Administration -> System preferences and search for the new EmailPatronWhenHoldIsPlaced syspref. It should be disabled by default - leave it disabled for now. 3) Search for a record and go to the Holds tab. Place a hold for your patron. 4) Go to your patron's account and go to the Notices tab. Confirm the HOLDPLACED_PATRON notice was NOT queued. 5) Enable the EmailPatronWhenHoldIsPlaced syspref. 6) Repeat steps 3 and 4. Confirm the HOLDPLACED_PATRON notice WAS generated and queued. 7) Confirm tests pass t/db_dependent/Holds.t Sponsored-by: Fire and Emergency New Zealand Signed-off-by: Kelly <kelly@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Just noting here that it might be good to test $patron->notice_email_address before enqueuing? Note that if SendQueuedMessages does not find an address, it will set status to failed in queue. No blocker. Pushed to master for 23.11. Nice work everyone, thanks! Enhancement not pushed to 23.05.x |