Bug 37436 - Move EmailPatronWhenHoldIsPlaced to holds policy system preferences
Summary: Move EmailPatronWhenHoldIsPlaced to holds policy system preferences
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Caroline Cyr La Rose
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 17617
Blocks:
  Show dependency tree / graph
 
Reported: 2024-07-23 16:03 UTC by Caroline Cyr La Rose
Modified: 2024-11-15 20:46 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This patch moves the EmailPatronWhenHoldIsPlaced system preference from Circulation > Patron restrictions to Circulation > Holds policy.
Version(s) released in:
24.11.00
Circulation function:

Attachments
Bug 37436: Move EmailPatronWhenHoldIsPlaced to Holds policy sysprefs (2.30 KB, patch)
2024-07-23 16:09 UTC, Caroline Cyr La Rose 		Details | Diff | Splinter Review
Bug 37436: Move EmailPatronWhenHoldIsPlaced to Holds policy sysprefs (2.35 KB, patch)
2024-07-24 14:14 UTC, ByWater Sandboxes 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-07-23 16:03:40 UTC 
The new EmailPatronWhenHoldIsPlaced system preference is in Circulation > Patron restrictions. However, it has nothing to do with patron restrictions.

I propose to move it to Circulation > Holds policy since it has to do with holds.

Another option could be Patrons > Notices and notifications since it has to do with sending a notice to the patron.
Comment 1 Caroline Cyr La Rose 2024-07-23 16:09:43 UTC 
Created attachment 169437 [details] [review]
Bug 37436: Move EmailPatronWhenHoldIsPlaced to Holds policy sysprefs

This patch moves the EmailPatronWhenHoldIsPlaced system preference
from Circulation > Patron restrictions to Circulation > Holds policy.

To test:
1. Apply patch
2. Go to Administration > System preferences > Circulation > Holds
   policy
   --> EmailPatronWhenHoldIsPlaced should be right after
       emailLibrarianWhenHoldIsPlaced
Comment 2 ByWater Sandboxes 2024-07-24 14:14:00 UTC 
Created attachment 169493 [details] [review]
Bug 37436: Move EmailPatronWhenHoldIsPlaced to Holds policy sysprefs

This patch moves the EmailPatronWhenHoldIsPlaced system preference
from Circulation > Patron restrictions to Circulation > Holds policy.

To test:
1. Apply patch
2. Go to Administration > System preferences > Circulation > Holds
   policy
   --> EmailPatronWhenHoldIsPlaced should be right after
       emailLibrarianWhenHoldIsPlaced

Signed-off-by: hebah <hebah@bywatersolutions.com>
Comment 3 hebah 2024-07-24 14:15:39 UTC 
Much more logical place for it, works as expected.
Comment 4 Katrin Fischer 2024-09-02 09:31:48 UTC 
QA'd by RM. Thanks Caroline!
Comment 5 Katrin Fischer 2024-09-02 10:21:29 UTC 
Pushed for 24.11!

Well done everyone, thank you!