Description
Jonathan Druart
2016-11-16 09:41:12 UTC
Created attachment 57530 [details] [review] Bug 17640: Fix t/db_dependent/Template/Plugin/Categories.t These tests fail since commit 6ee8dd3a597d08ccc5122473e55790d3f21d5163 Bug 15407: Koha::Patron::Categories - replace C4::Category->all Indeed the patron categories plugin now returns a Koha::Patron::Categories object and does not set a 'selected' flag. We do not need this flag (`git grep Categories.all **/*.tt` to trust me) Note that this patch also add a patron category to make the test passes even if no category exist. Test plan: prove t/db_dependent/Template/Plugin/Categories.t should return green Created attachment 57537 [details] [review] Bug 17640: Fix t/db_dependent/Template/Plugin/Categories.t These tests fail since commit 6ee8dd3a597d08ccc5122473e55790d3f21d5163 Bug 15407: Koha::Patron::Categories - replace C4::Category->all Indeed the patron categories plugin now returns a Koha::Patron::Categories object and does not set a 'selected' flag. We do not need this flag (`git grep Categories.all **/*.tt` to trust me) Note that this patch also add a patron category to make the test passes even if no category exist. Test plan: prove t/db_dependent/Template/Plugin/Categories.t should return green Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 57555 [details] [review] Bug 17640: Fix t/db_dependent/Template/Plugin/Categories.t These tests fail since commit 6ee8dd3a597d08ccc5122473e55790d3f21d5163 Bug 15407: Koha::Patron::Categories - replace C4::Category->all Indeed the patron categories plugin now returns a Koha::Patron::Categories object and does not set a 'selected' flag. We do not need this flag (`git grep Categories.all **/*.tt` to trust me) Note that this patch also add a patron category to make the test passes even if no category exist. Test plan: prove t/db_dependent/Template/Plugin/Categories.t should return green Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 57556 [details] [review] Bug 17640: (QA followup) Add more tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Created attachment 57557 [details] [review] Bug 17640: Fix t/db_dependent/Template/Plugin/Categories.t These tests fail since commit 6ee8dd3a597d08ccc5122473e55790d3f21d5163 Bug 15407: Koha::Patron::Categories - replace C4::Category->all Indeed the patron categories plugin now returns a Koha::Patron::Categories object and does not set a 'selected' flag. We do not need this flag (`git grep Categories.all **/*.tt` to trust me) Note that this patch also add a patron category to make the test passes even if no category exist. Test plan: prove t/db_dependent/Template/Plugin/Categories.t should return green Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 57558 [details] [review] Bug 17640: (QA followup) Add more tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 57559 [details] [review] Bug 17640 [QA Followup] - Remove any outstanding issues before removing patrons Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Pushed to master for 16.11, thanks Jonathan, Tomas! Created attachment 57567 [details] [review] Bug 17640: (Jonathan complain followup) Use Koha::*->search->delete instead Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Second followup pushed to master, thanks again Tomas! Pushed to 16.05.x, for 16.05.06 release |