Bug 17678

Summary: C4::Acquisition - Replace GetIssues with Koha::Checkouts
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Marcel de Rooy <m.de.rooy>
Severity: enhancement    
Priority: P5 - low CC: katrin.fischer, kyle, m.de.rooy
Version: master   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: Small patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 17796    
Bug Blocks: 17677    
Attachments: Bug 17678: Add tests for CanBookBeIssued + AllowMultipleIssuesOnABiblio
Bug 17678: C4::Circulation - Replace GetIssues with Koha::Issues
[SIGNED-OFF] Bug 17678: Add tests for CanBookBeIssued + AllowMultipleIssuesOnABiblio
[SIGNED-OFF] Bug 17678: C4::Circulation - Replace GetIssues with Koha::Issues
Bug 17678: Add tests for CanBookBeIssued + AllowMultipleIssuesOnABiblio
Bug 17678: C4::Circulation - Replace GetIssues with Koha::Issues
Bug 17678: Typo iss in Circulation.t
Bug 17678: Use Koha::Checkouts instead of Koha::Issues

Description Jonathan Druart 2016-11-25 10:16:41 UTC

    
Comment 1 Jonathan Druart 2016-11-25 10:20:32 UTC
Created attachment 57767 [details] [review]
Bug 17678: Add tests for CanBookBeIssued + AllowMultipleIssuesOnABiblio
Comment 2 Jonathan Druart 2016-11-25 10:20:36 UTC
Created attachment 57768 [details] [review]
Bug 17678: C4::Circulation - Replace GetIssues with Koha::Issues

The C4::Circulation::GetIssues subroutine is only called once and can be
replaced with a call to Koha::Isues->search with a join on items.

Test plan:
- Apply first patch and make sure the tests pass
- Apply second patch and make sure the tests still pass
Comment 3 Josef Moravec 2016-11-26 08:51:34 UTC
Created attachment 57777 [details] [review]
[SIGNED-OFF] Bug 17678: Add tests for CanBookBeIssued + AllowMultipleIssuesOnABiblio

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 4 Josef Moravec 2016-11-26 08:51:43 UTC
Created attachment 57778 [details] [review]
[SIGNED-OFF] Bug 17678: C4::Circulation - Replace GetIssues with Koha::Issues

The C4::Circulation::GetIssues subroutine is only called once and can be
replaced with a call to Koha::Isues->search with a join on items.

Test plan:
- Apply first patch and make sure the tests pass
- Apply second patch and make sure the tests still pass

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 5 Marcel de Rooy 2016-12-02 09:10:21 UTC
Created attachment 57903 [details] [review]
Bug 17678: Add tests for CanBookBeIssued + AllowMultipleIssuesOnABiblio

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Marcel de Rooy 2016-12-02 09:10:24 UTC
Created attachment 57904 [details] [review]
Bug 17678: C4::Circulation - Replace GetIssues with Koha::Issues

The C4::Circulation::GetIssues subroutine is only called once and can be
replaced with a call to Koha::Isues->search with a join on items.

Test plan:
- Apply first patch and make sure the tests pass
- Apply second patch and make sure the tests still pass

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Marcel de Rooy 2016-12-02 09:10:28 UTC
Created attachment 57905 [details] [review]
Bug 17678: Typo iss in Circulation.t

Iss should be is.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 8 Jonathan Druart 2016-12-20 13:45:56 UTC
Created attachment 58294 [details] [review]
Bug 17678: Use Koha::Checkouts instead of Koha::Issues
Comment 9 Kyle M Hall 2016-12-23 11:54:38 UTC
Pushed to master for 17.05, thanks Jonathan!
Comment 10 Katrin Fischer 2016-12-27 22:19:07 UTC
This won't get ported back to 16.11.x as it is an enhancement.