|
Description
Jonathan Druart
2016-11-25 10:16:41 UTC
Created attachment 57767 [details] [review] Bug 17678: Add tests for CanBookBeIssued + AllowMultipleIssuesOnABiblio Created attachment 57768 [details] [review] Bug 17678: C4::Circulation - Replace GetIssues with Koha::Issues The C4::Circulation::GetIssues subroutine is only called once and can be replaced with a call to Koha::Isues->search with a join on items. Test plan: - Apply first patch and make sure the tests pass - Apply second patch and make sure the tests still pass Created attachment 57777 [details] [review] [SIGNED-OFF] Bug 17678: Add tests for CanBookBeIssued + AllowMultipleIssuesOnABiblio Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 57778 [details] [review] [SIGNED-OFF] Bug 17678: C4::Circulation - Replace GetIssues with Koha::Issues The C4::Circulation::GetIssues subroutine is only called once and can be replaced with a call to Koha::Isues->search with a join on items. Test plan: - Apply first patch and make sure the tests pass - Apply second patch and make sure the tests still pass Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 57903 [details] [review] Bug 17678: Add tests for CanBookBeIssued + AllowMultipleIssuesOnABiblio Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 57904 [details] [review] Bug 17678: C4::Circulation - Replace GetIssues with Koha::Issues The C4::Circulation::GetIssues subroutine is only called once and can be replaced with a call to Koha::Isues->search with a join on items. Test plan: - Apply first patch and make sure the tests pass - Apply second patch and make sure the tests still pass Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 57905 [details] [review] Bug 17678: Typo iss in Circulation.t Iss should be is. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Created attachment 58294 [details] [review] Bug 17678: Use Koha::Checkouts instead of Koha::Issues Pushed to master for 17.05, thanks Jonathan! This won't get ported back to 16.11.x as it is an enhancement. |