Summary: | 'Top Most-circulated items' gives wrong results when filtering by checkout date | ||
---|---|---|---|
Product: | Koha | Reporter: | Katrin Fischer <katrin.fischer> |
Component: | Reports | Assignee: | Andrew Fuerste-Henry <andrew> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | normal | ||
Priority: | P5 - low | CC: | aleisha, andrew, fridolin.somers, lucas, marjorie.barry-vila, martin.renvoize, micah.bucy, victor |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: |
20.11.00, 20.05.04, 19.11.10
|
|
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 10188 | ||
Attachments: |
Bug 17801: Use issuedate for limits in Most Circulated Items
Bug 17801: Use issuedate for limits in Most Circulated Items Bug 17801: Use issuedate for limits in Most Circulated Items |
Description
Katrin Fischer
2016-12-21 08:55:09 UTC
Appears to be still valid. +1, still valid Created attachment 109246 [details] [review] Bug 17801: Use issuedate for limits in Most Circulated Items To test: 1 - Have two checkouts in old_issues issue 1: timestamp 2020-08-01 00:00:00, issuedate 2019-08-01 00:00:00 issue 2: timestamp 2020-07-01 00:00:00, issuedate 2019-07-01 00:00:00 2 - Perform a Most Circulated Items search for checkout dates 2020-06-01 to 2020-09-01. Both checkouts appear in search 3 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Neither checkout appears in search 4 - apply patch, restart all 5 - Repeat search with checkout dates 2020-06-01 to 2020-09-01. Neither checkout appears in search 6 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Both checkouts appears in search Created attachment 109588 [details] [review] Bug 17801: Use issuedate for limits in Most Circulated Items To test: 1 - Have two checkouts in old_issues issue 1: timestamp 2020-08-01 00:00:00, issuedate 2019-08-01 00:00:00 issue 2: timestamp 2020-07-01 00:00:00, issuedate 2019-07-01 00:00:00 2 - Perform a Most Circulated Items search for checkout dates 2020-06-01 to 2020-09-01. Both checkouts appear in search 3 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Neither checkout appears in search 4 - apply patch, restart all 5 - Repeat search with checkout dates 2020-06-01 to 2020-09-01. Neither checkout appears in search 6 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Both checkouts appears in search Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Indeed, timestamp can not be trusted. Nice work ;) Created attachment 109597 [details] [review] Bug 17801: Use issuedate for limits in Most Circulated Items To test: 1 - Have two checkouts in old_issues issue 1: timestamp 2020-08-01 00:00:00, issuedate 2019-08-01 00:00:00 issue 2: timestamp 2020-07-01 00:00:00, issuedate 2019-07-01 00:00:00 2 - Perform a Most Circulated Items search for checkout dates 2020-06-01 to 2020-09-01. Both checkouts appear in search 3 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Neither checkout appears in search 4 - apply patch, restart all 5 - Repeat search with checkout dates 2020-06-01 to 2020-09-01. Neither checkout appears in search 6 - Repeat search with checkout dates 2019-06-01 to 2019-09-01. Both checkouts appears in search Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Another nice old one to have squelched. Works well, trivial patch.. Passing QA > Side note: the report does also not seem to count current checkouts as it avoids the issues table? See Bug 10188 *** Bug 12628 has been marked as a duplicate of this bug. *** Pushed to master for 20.11, thanks to everybody involved! A lot of libraries have seen this bug, please backport to stable branches. backported to 20.05.x for 20.05.04 backported to 19.11.x for 19.11.10 Great :D thanks a lot Not backported to oldoldstable (19.05.x). Feel free to ask if it's needed. |