Description
Katrin Fischer
2017-01-10 15:32:53 UTC
The BULAC (http://www.bulac.fr/) would like to sponsor this development ! As long as “Change sponsored?” is set on “Seeking developer”, anyone wanting to quote us for the development of such a feature or just ask for more information is welcome to write to us: <sigb@bulac.fr>. On top of bug 20726, I am going to add the internal notes with the configuration columns setting on this bug report. Is this still planned? Created attachment 79127 [details] [review] Bug 17877: Add columns settings to the orders table on subscription-detail Test plan: - Apply this patch and make sure to restart memcached (to re-read the yaml file that is cached) - Go to Home › Administration › Columns settings - Confirm that a new "Serials" tab contain the different columns of the "Acquisition details" table displayed on the subscription detail page (if an order exist for this subscription) - Play with it - Go to Home › Serials › Details for subscription #ID - Confirm that the "Column visibility" button is now displayed on top of the table that it works correctly. Created attachment 79128 [details] [review] Bug 17877: Add the order's notes to the table This patch adds the vendor and internal note from the acquisition order to the subscription detail page Test plan: - Create an order from a subscription, fill the internal and vendor notes - Go to the subscription's detail page - Confirm that the columns are displayed in the "Acquisition details" table and contain the correct values - Make sure the "Home › Administration › Columns settings" admin page let you hide them by default (for those who will not need them). Patch tested with a sandbox, by Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 79136 [details] [review] Bug 17877: Add columns settings to the orders table on subscription-detail Test plan: - Apply this patch and make sure to restart memcached (to re-read the yaml file that is cached) - Go to Home › Administration › Columns settings - Confirm that a new "Serials" tab contain the different columns of the "Acquisition details" table displayed on the subscription detail page (if an order exist for this subscription) - Play with it - Go to Home › Serials › Details for subscription #ID - Confirm that the "Column visibility" button is now displayed on top of the table that it works correctly. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 79137 [details] [review] Bug 17877: Add the order's notes to the table This patch adds the vendor and internal note from the acquisition order to the subscription detail page Test plan: - Create an order from a subscription, fill the internal and vendor notes - Go to the subscription's detail page - Confirm that the columns are displayed in the "Acquisition details" table and contain the correct values - Make sure the "Home › Administration › Columns settings" admin page let you hide them by default (for those who will not need them). Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Created attachment 79355 [details] [review] Bug 17877: Add columns settings to the orders table on subscription-detail Test plan: - Apply this patch and make sure to restart memcached (to re-read the yaml file that is cached) - Go to Home › Administration › Columns settings - Confirm that a new "Serials" tab contain the different columns of the "Acquisition details" table displayed on the subscription detail page (if an order exist for this subscription) - Play with it - Go to Home › Serials › Details for subscription #ID - Confirm that the "Column visibility" button is now displayed on top of the table that it works correctly. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Created attachment 79356 [details] [review] Bug 17877: Add the order's notes to the table This patch adds the vendor and internal note from the acquisition order to the subscription detail page Test plan: - Create an order from a subscription, fill the internal and vendor notes - Go to the subscription's detail page - Confirm that the columns are displayed in the "Acquisition details" table and contain the correct values - Make sure the "Home › Administration › Columns settings" admin page let you hide them by default (for those who will not need them). Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Awesome work all! Pushed to master for 18.11 Enhancement will not be backported to 18.05.x series |