Bug 20365 will add the ability to create several pending orders on the same subscription. To make it clear we should add a history of the acquisition on the subscription detail page.
This will need to be pushed along with bug 20365.
Created attachment 75146 [details] [review] Bug 20726: Add new method Koha::Acquisition::Order->fund Can be moved to a separate bug report.
Created attachment 75147 [details] [review] Bug 20726: Add new method Acquisition::Order->invoice Can be moved to a separate bug report.
Created attachment 75148 [details] [review] Bug 20726: Add acquisition history on the subscription detail page Since bug 20365 is going to add the ability to create several pending orders on the same subscription we should display the history of the acquisitions on the subscription detail page.
Created attachment 75149 [details] [review] Bug 20726: Add DataTables
Created attachment 75150 [details] [review] Bug 20726: Remove GetLastOrder* subroutines They are not used elsewhere.
These patches are for discussion. 1. Do we want to display canceled orders? We display them on the bibliographic detail page. 2. Before we had 2 lines: one for the last received order and one for the last ordered order. Now that we have one line per order and more information displayed, what could be a good display for prices? (for patch displays "tax excluded/tax included" inside the same cell, which is not clear at all). 3. Still prices: Do we want a total? I guess so, but I do not think we should surcharge the display too much, and so it will be hard to have the included/excluded values + taxes. Any suggestions? 4. For the "Spent" values we display the unit price (previous behaviour), but the acquisition home page displays ecost as the spent value if unit price is not set. It sounds like we should do the same on this page (now? later?) 5. Bug 17877 would like the vendor and internal notes, we add them to this table? With configuration columns setting maybe?
6. Sort by default on which column? 7. Maybe add link to display/hide the already received orders? But in that case it will get harder if we display the total.
After discussion with staff working on that module, here are our opinions : (In reply to Jonathan Druart from comment #7) > These patches are for discussion. > > 1. Do we want to display canceled orders? We display them on the > bibliographic detail page. > It's not necessary to have them. > 2. Before we had 2 lines: one for the last received order and one for the > last ordered order. Now that we have one line per order and more information > displayed, what could be a good display for prices? (for patch displays "tax > excluded/tax included" inside the same cell, which is not clear at all). > The "Total tax excluded" price seems the better choice. > 3. Still prices: Do we want a total? I guess so, but I do not think we > should surcharge the display too much, and so it will be hard to have the > included/excluded values + taxes. > Any suggestions? > Total doesn't seem necessary. > 4. For the "Spent" values we display the unit price (previous behaviour), > but the acquisition home page displays ecost as the spent value if unit > price is not set. > It sounds like we should do the same on this page (now? later?) > No really opinion... > 5. Bug 17877 would like the vendor and internal notes, we add them to this > table? With configuration columns setting maybe? > As vendor is displayed just at the top on the "Information" tab, it could be useful if a subscription changed of vendor, but doesn’t seem to be a that necessary for us. We'd love to have internal notes ! A column setting option could be interesting to let everyone choose. (In reply to Jonathan Druart from comment #8) > 6. Sort by default on which column? > First on status ("New" // "Ordered" // "Complete"). Inside a status, order by aqordernumber (more recent at the top). > 7. Maybe add link to display/hide the already received orders? > But in that case it will get harder if we display the total. Good idea !
Created attachment 75650 [details] [review] Bug 20726: Add show/hide already received orders links
Created attachment 75651 [details] [review] Bug 20726: Sort by statuses then ordernumbers Not received and most recent at the top.
(In reply to Séverine Queune from comment #9) > After discussion with staff working on that module, here are our opinions : > > (In reply to Jonathan Druart from comment #7) > > These patches are for discussion. > > > > 1. Do we want to display canceled orders? We display them on the > > bibliographic detail page. > > > It's not necessary to have them. They will be at the bottom, let keep them for now and we will adjust later if needed. > > 2. Before we had 2 lines: one for the last received order and one for the > > last ordered order. Now that we have one line per order and more information > > displayed, what could be a good display for prices? (for patch displays "tax > > excluded/tax included" inside the same cell, which is not clear at all). > > > The "Total tax excluded" price seems the better choice. I did not change it, I would like to get other's feedback to know what would be better. > > 3. Still prices: Do we want a total? I guess so, but I do not think we > > should surcharge the display too much, and so it will be hard to have the > > included/excluded values + taxes. > > Any suggestions? > > > Total doesn't seem necessary. Good news :) > > 5. Bug 17877 would like the vendor and internal notes, we add them to this > > table? With configuration columns setting maybe? > > > As vendor is displayed just at the top on the "Information" tab, it could be > useful if a subscription changed of vendor, but doesn’t seem to be a that > necessary for us. > We'd love to have internal notes ! > A column setting option could be interesting to let everyone choose. Ok, will do later on bug 17877 then. > (In reply to Jonathan Druart from comment #8) > > 6. Sort by default on which column? > > > First on status ("New" // "Ordered" // "Complete"). > Inside a status, order by aqordernumber (more recent at the top). > > > 7. Maybe add link to display/hide the already received orders? > > But in that case it will get harder if we display the total. > Good idea ! Done! Changing status to Needs Signoff!
*** Bug 9898 has been marked as a duplicate of this bug. ***
(In reply to Jonathan Druart from comment #12) > (In reply to Séverine Queune from comment #9) > > > 2. Before we had 2 lines: one for the last received order and one for the > > > last ordered order. Now that we have one line per order and more information > > > displayed, what could be a good display for prices? (for patch displays "tax > > > excluded/tax included" inside the same cell, which is not clear at all). > > > > > The "Total tax excluded" price seems the better choice. > > I did not change it, I would like to get other's feedback to know what would > be better. I've got no problem with keeping it if others think it's better. In that case, I think it would be useful to have a tooltip to precise which prices are displayed. The link 'Hide already received orders' displays 'Complete' status orders instead of 'New', 'Ordered' and 'Cancelled'. The other points seem good for me !
Created attachment 75666 [details] [review] Bug 20726: Sort by statuses then ordernumbers Not received and most recent at the top.
(In reply to Séverine Queune from comment #14) > The link 'Hide already received orders' displays 'Complete' status orders > instead of 'New', 'Ordered' and 'Cancelled'. Ha! I was focused on how do to it and forgot what I wanted to hide :) That should be fixed now.
Created attachment 75708 [details] [review] Bug 20726: Add new method Koha::Acquisition::Order->fund Can be moved to a separate bug report. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 75709 [details] [review] Bug 20726: Add new method Acquisition::Order->invoice Can be moved to a separate bug report. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 75710 [details] [review] Bug 20726: Add acquisition history on the subscription detail page Since bug 20365 is going to add the ability to create several pending orders on the same subscription we should display the history of the acquisitions on the subscription detail page. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 75711 [details] [review] Bug 20726: Add DataTables Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 75712 [details] [review] Bug 20726: Add show/hide already received orders links Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Created attachment 75713 [details] [review] Bug 20726: Sort by statuses then ordernumbers Not received and most recent at the top. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>
Works as expected now :) What do you think about the tooltip or something similar ?
(In reply to Séverine Queune from comment #23) > Works as expected now :) > > What do you think about the tooltip or something similar ? Yes maybe, but I am not convinced. I would prefer to wait for another idea/opinion.
(In reply to Jonathan Druart from comment #24) > (In reply to Séverine Queune from comment #23) > > Works as expected now :) > > > > What do you think about the tooltip or something similar ? > > Yes maybe, but I am not convinced. I would prefer to wait for another > idea/opinion. It could be tooltip, or a sentence above table saying something like "All prices are shown as price without tax / price with tax" I have not strong opinion on the form of this help/tip, but I think it should be here.
Created attachment 75794 [details] [review] Bug 20726: Add title to the price column headers
Created attachment 77428 [details] [review] Bug 20726: Add new method Koha::Acquisition::Order->fund Can be moved to a separate bug report. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 77429 [details] [review] Bug 20726: Add new method Acquisition::Order->invoice Can be moved to a separate bug report. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 77430 [details] [review] Bug 20726: Add acquisition history on the subscription detail page Since bug 20365 is going to add the ability to create several pending orders on the same subscription we should display the history of the acquisitions on the subscription detail page. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 77431 [details] [review] Bug 20726: Add DataTables Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 77432 [details] [review] Bug 20726: Add show/hide already received orders links Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 77433 [details] [review] Bug 20726: Sort by statuses then ordernumbers Not received and most recent at the top. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 77434 [details] [review] Bug 20726: Add title to the price column headers Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Josef - will you work on the dependent bug as well?
bug 20365 specifically
(In reply to Katrin Fischer from comment #35) > bug 20365 specifically Done ;)
Thx :) Was just about to start there when I noticed you working on this one :)
Created attachment 77500 [details] [review] Bug 20726: Add new method Koha::Acquisition::Order->fund Can be moved to a separate bug report. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 77501 [details] [review] Bug 20726: Add new method Acquisition::Order->invoice Can be moved to a separate bug report. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 77502 [details] [review] Bug 20726: Add acquisition history on the subscription detail page Since bug 20365 is going to add the ability to create several pending orders on the same subscription we should display the history of the acquisitions on the subscription detail page. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 77503 [details] [review] Bug 20726: Add DataTables Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 77504 [details] [review] Bug 20726: Add show/hide already received orders links Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 77505 [details] [review] Bug 20726: Sort by statuses then ordernumbers Not received and most recent at the top. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 77506 [details] [review] Bug 20726: Add title to the price column headers Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78062 [details] [review] Bug 20726: Add new method Koha::Acquisition::Order->fund Can be moved to a separate bug report. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78063 [details] [review] Bug 20726: Add new method Acquisition::Order->invoice Can be moved to a separate bug report. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78064 [details] [review] Bug 20726: Add acquisition history on the subscription detail page Since bug 20365 is going to add the ability to create several pending orders on the same subscription we should display the history of the acquisitions on the subscription detail page. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78065 [details] [review] Bug 20726: Add DataTables Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78066 [details] [review] Bug 20726: Add show/hide already received orders links Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78067 [details] [review] Bug 20726: Sort by statuses then ordernumbers Not received and most recent at the top. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Created attachment 78068 [details] [review] Bug 20726: Add title to the price column headers Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Awesome work all! Pushed to master for 18.11
Enhancement, will not be backported to 18.05.x series.