Bug 20726 - Display acquisition details on the subscription detail page
Summary: Display acquisition details on the subscription detail page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Josef Moravec
URL:
Keywords:
: 9898 (view as bug list)
Depends on:
Blocks: 31554 17877 20365 20728
  Show dependency treegraph
 
Reported: 2018-05-07 23:30 UTC by Jonathan Druart
Modified: 2022-09-13 11:06 UTC (History)
6 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 20726: Add new method Koha::Acquisition::Order->fund (2.12 KB, patch)
2018-05-07 23:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Add new method Acquisition::Order->invoice (5.43 KB, patch)
2018-05-07 23:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Add acquisition history on the subscription detail page (9.79 KB, patch)
2018-05-07 23:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Add DataTables (1.92 KB, patch)
2018-05-07 23:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Remove GetLastOrder* subroutines (2.47 KB, patch)
2018-05-07 23:50 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Add show/hide already received orders links (3.44 KB, patch)
2018-05-29 20:11 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Sort by statuses then ordernumbers (2.70 KB, patch)
2018-05-29 20:11 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Sort by statuses then ordernumbers (3.09 KB, patch)
2018-05-30 14:27 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Add new method Koha::Acquisition::Order->fund (2.25 KB, patch)
2018-05-31 16:01 UTC, Séverine Queune
Details | Diff | Splinter Review
Bug 20726: Add new method Acquisition::Order->invoice (5.56 KB, patch)
2018-05-31 16:02 UTC, Séverine Queune
Details | Diff | Splinter Review
Bug 20726: Add acquisition history on the subscription detail page (9.92 KB, patch)
2018-05-31 16:02 UTC, Séverine Queune
Details | Diff | Splinter Review
Bug 20726: Add DataTables (2.05 KB, patch)
2018-05-31 16:02 UTC, Séverine Queune
Details | Diff | Splinter Review
Bug 20726: Add show/hide already received orders links (3.58 KB, patch)
2018-05-31 16:02 UTC, Séverine Queune
Details | Diff | Splinter Review
Bug 20726: Sort by statuses then ordernumbers (3.23 KB, patch)
2018-05-31 16:02 UTC, Séverine Queune
Details | Diff | Splinter Review
Bug 20726: Add title to the price column headers (1.22 KB, patch)
2018-06-04 20:12 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Add new method Koha::Acquisition::Order->fund (2.31 KB, patch)
2018-08-02 12:33 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 20726: Add new method Acquisition::Order->invoice (5.61 KB, patch)
2018-08-02 12:33 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 20726: Add acquisition history on the subscription detail page (9.98 KB, patch)
2018-08-02 12:33 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 20726: Add DataTables (2.11 KB, patch)
2018-08-02 12:33 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 20726: Add show/hide already received orders links (3.63 KB, patch)
2018-08-02 12:33 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 20726: Sort by statuses then ordernumbers (3.28 KB, patch)
2018-08-02 12:33 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 20726: Add title to the price column headers (1.27 KB, patch)
2018-08-02 12:33 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 20726: Add new method Koha::Acquisition::Order->fund (2.36 KB, patch)
2018-08-06 21:07 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Add new method Acquisition::Order->invoice (5.68 KB, patch)
2018-08-06 21:07 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Add acquisition history on the subscription detail page (10.04 KB, patch)
2018-08-06 21:07 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Add DataTables (2.16 KB, patch)
2018-08-06 21:07 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Add show/hide already received orders links (3.69 KB, patch)
2018-08-06 21:07 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Sort by statuses then ordernumbers (3.33 KB, patch)
2018-08-06 21:07 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Add title to the price column headers (1.32 KB, patch)
2018-08-06 21:07 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Add new method Koha::Acquisition::Order->fund (2.36 KB, patch)
2018-08-22 00:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Add new method Acquisition::Order->invoice (5.68 KB, patch)
2018-08-22 00:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Add acquisition history on the subscription detail page (10.19 KB, patch)
2018-08-22 00:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Add DataTables (2.18 KB, patch)
2018-08-22 00:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Add show/hide already received orders links (3.94 KB, patch)
2018-08-22 00:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Sort by statuses then ordernumbers (3.35 KB, patch)
2018-08-22 00:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 20726: Add title to the price column headers (1.32 KB, patch)
2018-08-22 00:53 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2018-05-07 23:30:08 UTC
Bug 20365 will add the ability to create several pending orders on the same subscription.

To make it clear we should add a history of the acquisition on the subscription detail page.
Comment 1 Jonathan Druart 2018-05-07 23:30:57 UTC
This will need to be pushed along with bug 20365.
Comment 2 Jonathan Druart 2018-05-07 23:50:22 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2018-05-07 23:50:26 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2018-05-07 23:50:29 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2018-05-07 23:50:33 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2018-05-07 23:50:37 UTC Comment hidden (obsolete)
Comment 7 Jonathan Druart 2018-05-07 23:52:23 UTC
These patches are for discussion.

1. Do we want to display canceled orders? We display them on the bibliographic detail page.

2. Before we had 2 lines: one for the last received order and one for the last ordered order. Now that we have one line per order and more information displayed, what could be a good display for prices? (for patch displays "tax excluded/tax included" inside the same cell, which is not clear at all).

3. Still prices: Do we want a total? I guess so, but I do not think we should surcharge the display too much, and so it will be hard to have the included/excluded values + taxes.
Any suggestions?

4. For the "Spent" values we display the unit price (previous behaviour), but the acquisition home page displays ecost as the spent value if unit price is not set.
It sounds like we should do the same on this page (now? later?)

5. Bug 17877 would like the vendor and internal notes, we add them to this table? With configuration columns setting maybe?
Comment 8 Jonathan Druart 2018-05-07 23:55:28 UTC
6. Sort by default on which column?

7. Maybe add link to display/hide the already received orders?
But in that case it will get harder if we display the total.
Comment 9 Séverine Queune 2018-05-11 11:52:18 UTC
After discussion with staff working on that module, here are our opinions : 

(In reply to Jonathan Druart from comment #7)
> These patches are for discussion.
> 
> 1. Do we want to display canceled orders? We display them on the
> bibliographic detail page.
> 
It's not necessary to have them.

> 2. Before we had 2 lines: one for the last received order and one for the
> last ordered order. Now that we have one line per order and more information
> displayed, what could be a good display for prices? (for patch displays "tax
> excluded/tax included" inside the same cell, which is not clear at all).
> 
The "Total tax excluded" price seems the better choice.

> 3. Still prices: Do we want a total? I guess so, but I do not think we
> should surcharge the display too much, and so it will be hard to have the
> included/excluded values + taxes.
> Any suggestions?
> 
Total doesn't seem necessary.

> 4. For the "Spent" values we display the unit price (previous behaviour),
> but the acquisition home page displays ecost as the spent value if unit
> price is not set.
> It sounds like we should do the same on this page (now? later?)
> 
No really opinion...

> 5. Bug 17877 would like the vendor and internal notes, we add them to this
> table? With configuration columns setting maybe?
>
As vendor is displayed just at the top on the "Information" tab, it could be useful if a subscription changed of vendor, but doesn’t seem to be a that necessary for us.
We'd love to have internal notes !
A column setting option could be interesting to let everyone choose.

(In reply to Jonathan Druart from comment #8)
> 6. Sort by default on which column?
> 
First on status ("New" // "Ordered" // "Complete").
Inside a status, order by aqordernumber (more recent at the top).

> 7. Maybe add link to display/hide the already received orders?
> But in that case it will get harder if we display the total.
Good idea !
Comment 10 Jonathan Druart 2018-05-29 20:11:44 UTC Comment hidden (obsolete)
Comment 11 Jonathan Druart 2018-05-29 20:11:48 UTC Comment hidden (obsolete)
Comment 12 Jonathan Druart 2018-05-29 20:14:17 UTC
(In reply to Séverine Queune from comment #9)
> After discussion with staff working on that module, here are our opinions : 
> 
> (In reply to Jonathan Druart from comment #7)
> > These patches are for discussion.
> > 
> > 1. Do we want to display canceled orders? We display them on the
> > bibliographic detail page.
> > 
> It's not necessary to have them.

They will be at the bottom, let keep them for now and we will adjust later if needed.

> > 2. Before we had 2 lines: one for the last received order and one for the
> > last ordered order. Now that we have one line per order and more information
> > displayed, what could be a good display for prices? (for patch displays "tax
> > excluded/tax included" inside the same cell, which is not clear at all).
> > 
> The "Total tax excluded" price seems the better choice.

I did not change it, I would like to get other's feedback to know what would be better.

> > 3. Still prices: Do we want a total? I guess so, but I do not think we
> > should surcharge the display too much, and so it will be hard to have the
> > included/excluded values + taxes.
> > Any suggestions?
> > 
> Total doesn't seem necessary.

Good news :)

> > 5. Bug 17877 would like the vendor and internal notes, we add them to this
> > table? With configuration columns setting maybe?
> >
> As vendor is displayed just at the top on the "Information" tab, it could be
> useful if a subscription changed of vendor, but doesn’t seem to be a that
> necessary for us.
> We'd love to have internal notes !
> A column setting option could be interesting to let everyone choose.

Ok, will do later on bug 17877 then.

> (In reply to Jonathan Druart from comment #8)
> > 6. Sort by default on which column?
> > 
> First on status ("New" // "Ordered" // "Complete").
> Inside a status, order by aqordernumber (more recent at the top).
> 
> > 7. Maybe add link to display/hide the already received orders?
> > But in that case it will get harder if we display the total.
> Good idea !

Done!

Changing status to Needs Signoff!
Comment 13 Jonathan Druart 2018-05-29 20:15:06 UTC
*** Bug 9898 has been marked as a duplicate of this bug. ***
Comment 14 Séverine Queune 2018-05-30 08:44:29 UTC
(In reply to Jonathan Druart from comment #12)
> (In reply to Séverine Queune from comment #9)

> > > 2. Before we had 2 lines: one for the last received order and one for the
> > > last ordered order. Now that we have one line per order and more information
> > > displayed, what could be a good display for prices? (for patch displays "tax
> > > excluded/tax included" inside the same cell, which is not clear at all).
> > > 
> > The "Total tax excluded" price seems the better choice.
> 
> I did not change it, I would like to get other's feedback to know what would
> be better.
I've got no problem with keeping it if others think it's better.
In that case, I think it would be useful to have a tooltip to precise which prices are displayed.

The link 'Hide already received orders' displays 'Complete' status orders instead of 'New', 'Ordered' and 'Cancelled'.

The other points seem good for me !
Comment 15 Jonathan Druart 2018-05-30 14:27:53 UTC Comment hidden (obsolete)
Comment 16 Jonathan Druart 2018-05-30 14:28:58 UTC
(In reply to Séverine Queune from comment #14)
> The link 'Hide already received orders' displays 'Complete' status orders
> instead of 'New', 'Ordered' and 'Cancelled'.

Ha! I was focused on how do to it and forgot what I wanted to hide :)
That should be fixed now.
Comment 17 Séverine Queune 2018-05-31 16:01:59 UTC Comment hidden (obsolete)
Comment 18 Séverine Queune 2018-05-31 16:02:02 UTC Comment hidden (obsolete)
Comment 19 Séverine Queune 2018-05-31 16:02:06 UTC Comment hidden (obsolete)
Comment 20 Séverine Queune 2018-05-31 16:02:09 UTC Comment hidden (obsolete)
Comment 21 Séverine Queune 2018-05-31 16:02:13 UTC Comment hidden (obsolete)
Comment 22 Séverine Queune 2018-05-31 16:02:17 UTC Comment hidden (obsolete)
Comment 23 Séverine Queune 2018-05-31 16:04:09 UTC
Works as expected now :)

What do you think about the tooltip or something similar ?
Comment 24 Jonathan Druart 2018-06-01 13:43:43 UTC
(In reply to Séverine Queune from comment #23)
> Works as expected now :)
> 
> What do you think about the tooltip or something similar ?

Yes maybe, but I am not convinced. I would prefer to wait for another idea/opinion.
Comment 25 Josef Moravec 2018-06-04 13:57:22 UTC
(In reply to Jonathan Druart from comment #24)
> (In reply to Séverine Queune from comment #23)
> > Works as expected now :)
> > 
> > What do you think about the tooltip or something similar ?
> 
> Yes maybe, but I am not convinced. I would prefer to wait for another
> idea/opinion.

It could be tooltip, or a sentence above table saying something like "All prices are shown as price without tax / price with tax"

I have not strong opinion on the form of this help/tip, but I think it should be here.
Comment 26 Jonathan Druart 2018-06-04 20:12:07 UTC Comment hidden (obsolete)
Comment 27 Josef Moravec 2018-08-02 12:33:09 UTC Comment hidden (obsolete)
Comment 28 Josef Moravec 2018-08-02 12:33:13 UTC Comment hidden (obsolete)
Comment 29 Josef Moravec 2018-08-02 12:33:16 UTC Comment hidden (obsolete)
Comment 30 Josef Moravec 2018-08-02 12:33:20 UTC Comment hidden (obsolete)
Comment 31 Josef Moravec 2018-08-02 12:33:24 UTC Comment hidden (obsolete)
Comment 32 Josef Moravec 2018-08-02 12:33:28 UTC Comment hidden (obsolete)
Comment 33 Josef Moravec 2018-08-02 12:33:31 UTC Comment hidden (obsolete)
Comment 34 Katrin Fischer 2018-08-02 12:45:16 UTC
Josef - will you work on the dependent bug as well?
Comment 35 Katrin Fischer 2018-08-02 12:45:51 UTC
bug 20365 specifically
Comment 36 Josef Moravec 2018-08-02 13:06:34 UTC
(In reply to Katrin Fischer from comment #35)
> bug 20365 specifically

Done ;)
Comment 37 Katrin Fischer 2018-08-02 13:07:42 UTC
Thx :) Was just about to start there when I noticed you working on this one :)
Comment 38 Jonathan Druart 2018-08-06 21:07:22 UTC
Created attachment 77500 [details] [review]
Bug 20726: Add new method Koha::Acquisition::Order->fund

Can be moved to a separate bug report.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 39 Jonathan Druart 2018-08-06 21:07:27 UTC
Created attachment 77501 [details] [review]
Bug 20726: Add new method Acquisition::Order->invoice

Can be moved to a separate bug report.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 40 Jonathan Druart 2018-08-06 21:07:32 UTC
Created attachment 77502 [details] [review]
Bug 20726: Add acquisition history on the subscription detail page

Since bug 20365 is going to add the ability to create several pending orders on
the same subscription we should display the history of the acquisitions on the
subscription detail page.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 41 Jonathan Druart 2018-08-06 21:07:36 UTC
Created attachment 77503 [details] [review]
Bug 20726: Add DataTables

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 42 Jonathan Druart 2018-08-06 21:07:41 UTC
Created attachment 77504 [details] [review]
Bug 20726: Add show/hide already received orders links

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 43 Jonathan Druart 2018-08-06 21:07:45 UTC
Created attachment 77505 [details] [review]
Bug 20726: Sort by statuses then ordernumbers

Not received and most recent at the top.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 44 Jonathan Druart 2018-08-06 21:07:49 UTC
Created attachment 77506 [details] [review]
Bug 20726: Add title to the price column headers

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 45 Jonathan Druart 2018-08-22 00:53:05 UTC
Created attachment 78062 [details] [review]
Bug 20726: Add new method Koha::Acquisition::Order->fund

Can be moved to a separate bug report.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 46 Jonathan Druart 2018-08-22 00:53:11 UTC
Created attachment 78063 [details] [review]
Bug 20726: Add new method Acquisition::Order->invoice

Can be moved to a separate bug report.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 47 Jonathan Druart 2018-08-22 00:53:17 UTC
Created attachment 78064 [details] [review]
Bug 20726: Add acquisition history on the subscription detail page

Since bug 20365 is going to add the ability to create several pending orders on
the same subscription we should display the history of the acquisitions on the
subscription detail page.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 48 Jonathan Druart 2018-08-22 00:53:22 UTC
Created attachment 78065 [details] [review]
Bug 20726: Add DataTables

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 49 Jonathan Druart 2018-08-22 00:53:28 UTC
Created attachment 78066 [details] [review]
Bug 20726: Add show/hide already received orders links

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 50 Jonathan Druart 2018-08-22 00:53:33 UTC
Created attachment 78067 [details] [review]
Bug 20726: Sort by statuses then ordernumbers

Not received and most recent at the top.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr>

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 51 Jonathan Druart 2018-08-22 00:53:39 UTC
Created attachment 78068 [details] [review]
Bug 20726: Add title to the price column headers

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 52 Nick Clemens 2018-08-30 14:09:04 UTC
Awesome work all!

Pushed to master for 18.11
Comment 53 Martin Renvoize 2018-09-05 10:52:25 UTC
Enhancement, will not be backported to 18.05.x series.