Summary: | On shelf holds allowed > "If all unavailable" ignores notforloan | ||
---|---|---|---|
Product: | Koha | Reporter: | Mirko Tietgen <mirko> |
Component: | Hold requests | Assignee: | Mirko Tietgen <mirko> |
Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
Severity: | major | ||
Priority: | P5 - low | CC: | gmcharlt, jonathan.druart, kyle, mtj |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18547 | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | 15534 | ||
Bug Blocks: | |||
Attachments: |
Bug 18015 - On shelf holds allowed > "If all unavailable" ignores notforloan
Bug 18015 - On shelf holds allowed > "If all unavailable" ignores notforloan Bug 18015 - On shelf holds allowed > "If all unavailable" ignores notforloan |
Description
Mirko Tietgen
2017-01-30 14:56:25 UTC
Created attachment 59646 [details] [review] Bug 18015 - On shelf holds allowed > "If all unavailable" ignores notforloan If in the circ rules matrix you set "On shelf holds allowed" to "If all unavailable", items with status "Not for loan" are considered available and break the functionality. Test plan: - Set "On shelf holds allowed" to "If all unavailable" for your patron and item category (or everyone and everything) - Have two items for a record. Check out one - Set 7 - Not for loan: "Not For Loan" for the second item - Try to place a hold. Does not work. - Apply the patch - Try to place a hold. Should work now. Created attachment 59649 [details] [review] Bug 18015 - On shelf holds allowed > "If all unavailable" ignores notforloan If in the circ rules matrix you set "On shelf holds allowed" to "If all unavailable", items with status "Not for loan" are considered available and break the functionality. Test plan: - Set "On shelf holds allowed" to "If all unavailable" for your patron and item category (or everyone and everything) - Have two items for a record. Check out one - Set 7 - Not for loan: "Not For Loan" for the second item - Try to place a hold. Does not work. - Apply the patch - Try to place a hold. Should work now. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Created attachment 59676 [details] [review] Bug 18015 - On shelf holds allowed > "If all unavailable" ignores notforloan If in the circ rules matrix you set "On shelf holds allowed" to "If all unavailable", items with status "Not for loan" are considered available and break the functionality. Test plan: - Set "On shelf holds allowed" to "If all unavailable" for your patron and item category (or everyone and everything) - Have two items for a record. Check out one - Set 7 - Not for loan: "Not For Loan" for the second item - Try to place a hold. Does not work. - Apply the patch - Try to place a hold. Should work now. Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Must be backported to 16.11 and 16.05 Pushed to master for 17.05, thanks Mirko! This patch has been pushed to 16.11.x and will be in 16.11.04. (In reply to Jonathan Druart from comment #4) > Must be backported to 16.11 and 16.05 Pushed to 16.05.x, for 16.05.10 release |