Bug 18033

Summary: If/else sometimes does not make sense after koha account system refactoring
Product: Koha Reporter: Josef Moravec <josef.moravec>
Component: Architecture, internals, and plumbingAssignee: Josef Moravec <josef.moravec>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: katrin.fischer, kyle
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 15894    
Bug Blocks:    
Attachments: Bug 18033: Remove duplicate code in paycollect.pl
Bug 18033: Remove duplicate code in paycollect.pl
Bug 18033: Remove duplicate code in paycollect.pl

Description Josef Moravec 2017-02-01 19:45:20 UTC
Patch folowing
Comment 1 Josef Moravec 2017-02-01 19:52:18 UTC
Created attachment 59752 [details] [review]
Bug 18033: Remove duplicate code in paycollect.pl

Test plan:
0) apply the patch
1) try to pay individual fee, with full amount and partial amount
   it should work the same as before patch
Comment 2 Kyle M Hall 2017-02-02 11:36:30 UTC
Created attachment 59797 [details] [review]
Bug 18033: Remove duplicate code in paycollect.pl

Test plan:
0) apply the patch
1) try to pay individual fee, with full amount and partial amount
   it should work the same as before patch

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 3 Jonathan Druart 2017-02-02 12:28:34 UTC
Created attachment 59810 [details] [review]
Bug 18033: Remove duplicate code in paycollect.pl

Test plan:
0) apply the patch
1) try to pay individual fee, with full amount and partial amount
   it should work the same as before patch

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Kyle M Hall 2017-02-07 16:15:56 UTC
Pushed to master for 17.05, thanks Josef!
Comment 5 Katrin Fischer 2017-02-07 21:00:25 UTC
This won't get ported back to 16.11.x as it is an enhancement.

I also suspect dependencies on the ongoing work to improve everything related to accounts and payments.