| Summary: | If/else sometimes does not make sense after koha account system refactoring | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Josef Moravec <josef.moravec> |
| Component: | Architecture, internals, and plumbing | Assignee: | Josef Moravec <josef.moravec> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | enhancement | ||
| Priority: | P5 - low | CC: | kyle |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | --- |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 15894 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 18033: Remove duplicate code in paycollect.pl
Bug 18033: Remove duplicate code in paycollect.pl Bug 18033: Remove duplicate code in paycollect.pl |
||
|
Description
Josef Moravec
2017-02-01 19:45:20 UTC
Created attachment 59752 [details] [review] Bug 18033: Remove duplicate code in paycollect.pl Test plan: 0) apply the patch 1) try to pay individual fee, with full amount and partial amount it should work the same as before patch Created attachment 59797 [details] [review] Bug 18033: Remove duplicate code in paycollect.pl Test plan: 0) apply the patch 1) try to pay individual fee, with full amount and partial amount it should work the same as before patch Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 59810 [details] [review] Bug 18033: Remove duplicate code in paycollect.pl Test plan: 0) apply the patch 1) try to pay individual fee, with full amount and partial amount it should work the same as before patch Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Pushed to master for 17.05, thanks Josef! This won't get ported back to 16.11.x as it is an enhancement. I also suspect dependencies on the ongoing work to improve everything related to accounts and payments. |