Summary: | Updating buttons for z39.50 cataloguing search | ||
---|---|---|---|
Product: | Koha | Reporter: | Aleisha Amohia <aleisha> |
Component: | Cataloging | Assignee: | Aleisha Amohia <aleisha> |
Status: | CLOSED WORKSFORME | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | josef.moravec, m.de.rooy, veron |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Small patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Circulation function: | |||
Bug Depends on: | |||
Bug Blocks: | 17873 | ||
Attachments: |
Bug 18043: Updating buttons for z39.50 cataloguing search
Bug 18043: Updating buttons for z39.50 cataloguing search Bug 18043: Updating buttons for z39.50 cataloguing search |
Description
Aleisha Amohia
2017-02-03 00:02:46 UTC
Created attachment 59837 [details] [review] Bug 18043: Updating buttons for z39.50 cataloguing search 1) Go to Cataloguing -> New from Z39.50 2) Do a search, noticing the ugly buttons from Comment 1 3) Apply patch and go back to a new search 4) Do a search again, noticing the new, nicer buttons 5) Confirm they still work as expected Sponsored-by: Catalyst IT I am for fa icons on buttons Search, Go and Try another search, ccing Owen to get his opinion... Created attachment 59960 [details] [review] Bug 18043: Updating buttons for z39.50 cataloguing search 1) Go to Cataloguing -> New from Z39.50 2) Do a search, noticing the ugly buttons from Comment 1 3) Apply patch and go back to a new search 4) Do a search again, noticing the new, nicer buttons 5) Confirm they still work as expected Sponsored-by: Catalyst IT Buttons display as expected, but "Go to page" is broken. Reason: Button "Go" definition misses: value="Go" If I add it (line 212), "Go to page" works. Created attachment 60361 [details] [review] Bug 18043: Updating buttons for z39.50 cataloguing search 1) Go to Cataloguing -> New from Z39.50 2) Do a search, noticing the ugly buttons from Comment 1 3) Apply patch and go back to a new search 4) Do a search again, noticing the new, nicer buttons 5) Confirm they still work as expected Sponsored-by: Catalyst IT (In reply to Marc Véron from comment #4) > Buttons display as expected, but "Go to page" is broken. > Reason: Button "Go" definition misses: value="Go" > If I add it (line 212), "Go to page" works. Fixed in latest patch. Ready for signoff "Go" button works now, but not next / previous page buttons. Oh, they miss 'value' as well (value="Next page" / value="Previous page") I think this has also been resolved with the staff interface redesign and some other changes since this was filed. |