Bug 18043 - Updating buttons for z39.50 cataloguing search
Summary: Updating buttons for z39.50 cataloguing search
Status: RESOLVED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 17873
  Show dependency treegraph
 
Reported: 2017-02-03 00:02 UTC by Aleisha Amohia
Modified: 2023-09-10 12:04 UTC (History)
3 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 18043: Updating buttons for z39.50 cataloguing search (5.95 KB, patch)
2017-02-03 00:04 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 18043: Updating buttons for z39.50 cataloguing search (6.12 KB, patch)
2017-02-06 23:05 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 18043: Updating buttons for z39.50 cataloguing search (6.15 KB, patch)
2017-02-16 19:50 UTC, Aleisha Amohia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aleisha Amohia 2017-02-03 00:02:46 UTC
Buttons that need to use bootstrap 3/font awesome icons:
- Search
- MARC (fa)
- Card (fa)
- Import (fa)
- Previous page/Next page
- Go
- Try another search
Comment 1 Aleisha Amohia 2017-02-03 00:04:55 UTC
Created attachment 59837 [details] [review]
Bug 18043: Updating buttons for z39.50 cataloguing search

1) Go to Cataloguing -> New from Z39.50
2) Do a search, noticing the ugly buttons from Comment 1
3) Apply patch and go back to a new search
4) Do a search again, noticing the new, nicer buttons
5) Confirm they still work as expected

Sponsored-by: Catalyst IT
Comment 2 Josef Moravec 2017-02-03 09:26:54 UTC
I am for fa icons on buttons Search, Go and Try another search, ccing Owen to get his opinion...
Comment 3 Aleisha Amohia 2017-02-06 23:05:50 UTC
Created attachment 59960 [details] [review]
Bug 18043: Updating buttons for z39.50 cataloguing search

1) Go to Cataloguing -> New from Z39.50
2) Do a search, noticing the ugly buttons from Comment 1
3) Apply patch and go back to a new search
4) Do a search again, noticing the new, nicer buttons
5) Confirm they still work as expected

Sponsored-by: Catalyst IT
Comment 4 Marc Véron 2017-02-10 14:31:40 UTC
Buttons display as expected, but "Go to page" is broken.
Reason: Button "Go" definition misses: value="Go"
If I add it (line 212), "Go to page" works.
Comment 5 Aleisha Amohia 2017-02-16 19:50:32 UTC
Created attachment 60361 [details] [review]
Bug 18043: Updating buttons for z39.50 cataloguing search

1) Go to Cataloguing -> New from Z39.50
2) Do a search, noticing the ugly buttons from Comment 1
3) Apply patch and go back to a new search
4) Do a search again, noticing the new, nicer buttons
5) Confirm they still work as expected

Sponsored-by: Catalyst IT
Comment 6 Aleisha Amohia 2017-02-16 19:51:03 UTC
(In reply to Marc Véron from comment #4)
> Buttons display as expected, but "Go to page" is broken.
> Reason: Button "Go" definition misses: value="Go"
> If I add it (line 212), "Go to page" works.

Fixed in latest patch. Ready for signoff
Comment 7 Marc Véron 2017-02-17 04:29:19 UTC
"Go" button works now, but not next / previous page buttons. Oh, they miss 'value' as well (value="Next page" / value="Previous page")
Comment 8 Katrin Fischer 2023-09-10 12:04:54 UTC
I think this has also been resolved with the staff interface redesign and some other changes since this was filed.