Bug 18230

Summary: Generate Koha::Patron::Modification verification_token in ->new
Product: Koha Reporter: Lari Taskula <lari.taskula>
Component: Architecture, internals, and plumbingAssignee: Bugs List <koha-bugs>
Status: Failed QA --- QA Contact: Testopia <testopia>
Severity: enhancement    
Priority: P5 - low CC: jonathan.druart
Version: Main   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 18230: Generate verification_token in Koha::Patron::Modification->new

Description Lari Taskula 2017-03-08 15:35:32 UTC
Currently verification_token is generated outside of the class. Move this logic into Koha::Patron::Modification->new.
Comment 1 Lari Taskula 2017-03-09 13:45:24 UTC
Created attachment 60949 [details] [review]
Bug 18230: Generate verification_token in Koha::Patron::Modification->new

To test:
1. prove t/db_dependent/Koha/Patron/Modifications.t
Comment 2 Jonathan Druart 2017-09-26 18:44:31 UTC
(In reply to Lari Taskula from comment #0)
> Currently verification_token is generated outside of the class. Move this
> logic into Koha::Patron::Modification->new.

Ok but with this patch you are not moving it, you are duplicating it.