Bug 18230 - Generate Koha::Patron::Modification verification_token in ->new
Summary: Generate Koha::Patron::Modification verification_token in ->new
Status: Failed QA
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-03-08 15:35 UTC by Lari Taskula
Modified: 2020-03-17 21:36 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 18230: Generate verification_token in Koha::Patron::Modification->new (2.62 KB, patch)
2017-03-09 13:45 UTC, Lari Taskula
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lari Taskula 2017-03-08 15:35:32 UTC
Currently verification_token is generated outside of the class. Move this logic into Koha::Patron::Modification->new.
Comment 1 Lari Taskula 2017-03-09 13:45:24 UTC
Created attachment 60949 [details] [review]
Bug 18230: Generate verification_token in Koha::Patron::Modification->new

To test:
1. prove t/db_dependent/Koha/Patron/Modifications.t
Comment 2 Jonathan Druart 2017-09-26 18:44:31 UTC
(In reply to Lari Taskula from comment #0)
> Currently verification_token is generated outside of the class. Move this
> logic into Koha::Patron::Modification->new.

Ok but with this patch you are not moving it, you are duplicating it.