| Summary: | Export is broken unless a file is supplied | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Jonathan Druart <jonathan.druart> |
| Component: | Tools | Assignee: | Jonathan Druart <jonathan.druart> |
| Status: | CLOSED FIXED | QA Contact: | Marcel de Rooy <m.de.rooy> |
| Severity: | critical | ||
| Priority: | P5 - low | CC: | ahmad.najeh, kyle, m.de.rooy, mtj, nick, steven.schmieder, tomascohen |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 15451, 18087 | ||
| Bug Blocks: | |||
| Attachments: |
Bug 18312: Fix export unless a file is supplied
Bug 18312: Fix export unless a file is supplied Bug 18312: Fix export unless a file is supplied |
||
|
Description
Jonathan Druart
2017-03-21 14:24:13 UTC
Created attachment 61391 [details] [review] Bug 18312: Fix export unless a file is supplied Bug 18087 breaks export unless a file is supplied. Can't use an undefined value as a HASH reference at /home/vagrant/kohaclone/tools/export.pl line 75. Test plan: Export records using a file of id that is not a valid file (not txt or csv) Export records using a valid file Export records without supplying a file => The export should work or fail as expected. *** Bug 18311 has been marked as a duplicate of this bug. *** Created attachment 61434 [details] [review] Bug 18312: Fix export unless a file is supplied Bug 18087 breaks export unless a file is supplied. Can't use an undefined value as a HASH reference at /home/vagrant/kohaclone/tools/export.pl line 75. Test plan: Export records using a file of id that is not a valid file (not txt or csv) Export records using a valid file Export records without supplying a file => The export should work or fail as expected. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> I get an empty file no matter what I do. Tried with a 'biblios' file with valid biblionumbers, tried renaming to 'biblios.txt' and even tried without a file. The result is always an empty .mrc file. (In reply to Tomás Cohen Arazi from comment #4) > I get an empty file no matter what I do. Tried with a 'biblios' file with > valid biblionumbers, tried renaming to 'biblios.txt' and even tried without > a file. The result is always an empty .mrc file. Works ok for me, please give it another try. It impacts stable release, upping severity. Please QA ASAP Last one :) (In reply to Tomás Cohen Arazi from comment #4) > I get an empty file no matter what I do. Tried with a 'biblios' file with > valid biblionumbers, tried renaming to 'biblios.txt' and even tried without > a file. The result is always an empty .mrc file. Problem reproduced. Created attachment 61609 [details] [review] Bug 18312: Fix export unless a file is supplied Bug 18087 breaks export unless a file is supplied. Can't use an undefined value as a HASH reference at /home/vagrant/kohaclone/tools/export.pl line 75. Test plan: Export records using a file of id that is not a valid file (not txt or csv) Export records using a valid file Export records without supplying a file => The export should work or fail as expected. Signed-off-by: Jesse Maseto <jesse@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> (In reply to Marcel de Rooy from comment #8) > (In reply to Tomás Cohen Arazi from comment #4) > > I get an empty file no matter what I do. Tried with a 'biblios' file with > > valid biblionumbers, tried renaming to 'biblios.txt' and even tried without > > a file. The result is always an empty .mrc file. > > Problem reproduced. I do not understand, Tomas is saying that the patch is buggy, you confirmed, but PQA? (In reply to Jonathan Druart from comment #10) > (In reply to Marcel de Rooy from comment #8) > > (In reply to Tomás Cohen Arazi from comment #4) > > > I get an empty file no matter what I do. Tried with a 'biblios' file with > > > valid biblionumbers, tried renaming to 'biblios.txt' and even tried without > > > a file. The result is always an empty .mrc file. > > > > Problem reproduced. > > I do not understand, Tomas is saying that the patch is buggy, you confirmed, > but PQA? No, I confirm that the problem can be reproduced. And the patch resolves it. (In reply to Marcel de Rooy from comment #11) > (In reply to Jonathan Druart from comment #10) > > (In reply to Marcel de Rooy from comment #8) > > > (In reply to Tomás Cohen Arazi from comment #4) > > > > I get an empty file no matter what I do. Tried with a 'biblios' file with > > > > valid biblionumbers, tried renaming to 'biblios.txt' and even tried without > > > > a file. The result is always an empty .mrc file. > > > > > > Problem reproduced. > > > > I do not understand, Tomas is saying that the patch is buggy, you confirmed, > > but PQA? > > No, I confirm that the problem can be reproduced. And the patch resolves it. Problem reproduced == Internal server error. Pushed to master for 17.05, thanks Jonathan! *** Bug 18301 has been marked as a duplicate of this bug. *** This patch has been pushed to 16.11.x and will be in 16.11.07. Blocked by Enhancement, skipping for 16.05.x Hi, We have koha version "'when I tried to export record per item type I got this message Software error: DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column 'biblioitems.itemtype' in 'where clause' at /usr/share/koha/lib/Koha/Objects.pm line 150 For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. Anybody can help?Please. Thanks Ahmad (In reply to Ahmad Najeh from comment #17) > Software error: > DBIx::Class::Storage::DBI::_dbh_execute(): Unknown column > 'biblioitems.itemtype' in 'where clause' at > /usr/share/koha/lib/Koha/Objects.pm line 150 > For help, please send mail to the webmaster ([no address given]), giving > this error message and the time and date of the error. Please open a new bug report with more information. |