| Summary: | Manage MARC import DBH should not be shared | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Fridolin Somers <fridolin.somers> |
| Component: | Tools | Assignee: | Fridolin Somers <fridolin.somers> |
| Status: | RESOLVED DUPLICATE | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | jonathan.druart |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7790 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16880 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18329 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17240 |
||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 8970 | ||
| Bug Blocks: | |||
| Attachments: | Bug 18343 - Manage MARC import DBH should not be shared | ||
|
Description
Fridolin Somers
2017-03-28 07:32:31 UTC
Created attachment 61659 [details] [review] Bug 18343 - Manage MARC import DBH should not be shared Bug 8970 reported an issue with stage-marc-import.pl sharing the DB handler in Plack context. There is the same issue with tools/manage-marc-import.pl. To create a transaction, one must create a new DB handler. Test plan : - In Staff interface Tools - Go to "Stage MARC records for import" - Import a marc records file with several records - Click on "Manage staged records" - Click on "Import this batch into the catalog" - Click on "Undo import into catalog" Test with and without Plack. To test with Plack you may apply Bug 17240. I've created this patch in order to do like Bug 8970, mainly for stable branches. Maybe another must change to use DBIx transactions like in Bug 18329. Why do not you implement transaction using DBIx::Class directly? That will be easier and backportable as well. (In reply to Jonathan Druart from comment #3) > Why do not you implement transaction using DBIx::Class directly? > That will be easier and backportable as well. It was to have a quick fix. Is it backportable to 3.22 ? The quick fix is to use DBIx::Class transactions. |