|
Description
Alex Buckley
2017-03-29 05:38:46 UTC
Created attachment 61666 [details] [review] Bug 17855: Onboarding tool Created attachment 62354 [details] [review] Bug 18346 - Implemented basic and advanced setup modes for step 3 of the web installer 1. Drop and recreate your database 2. Clear memcached 3. Run through the web installer up to the start of step 3 4. Notice that the 'Choose your setup' page there are only 2 radiobutton options on the page: UNIMARC and MARC21 and neither are selected by default 5. Select MARC21 and click 'Next' 6. The 'Select default settings' page appears. Notice that the top checkboxes under the 'Mandatory' headings are selected by default (but can be unselected and checkboxes under the 'optional' header are not selected by default and can be selected 7. Do not select any checkboxes, leave the default checkboxes selected and click the 'Import' button 8. The 'Selected data added' page appears click 'Finish' button 9. Apply patch, also apply bug 18039 10. Repeat steps 1, and 3 11. Notice the 'Choose your setup' page has 4 radiobutton options, the two new options are 'Basic' and 'Advanced', with 'Basic' selected by default. Also notice that 'MARC21' radiobutton is selected by default. 12. Click 'Next' button 13. Notice on the 'Selecting default settings' page instead of default selected radiobuttons under the header of 'Mandatory' there are bulleted descriptions of files under the header 'Default'. As shown in the screenshots in the '9.1.1. MARC21 Basic setup' section of this document: https://koha-community.org/manual/installation/html/web_installer_marc21_setup.html Also notice as you scroll down there are unselected radiobuttons under the 'Optional' heading 14. Do not select anything and click the 'Import' button 15. The 'Selected data added' page appears click the 'Finish' button 16. Repeat steps 1,2,3 17. Select 'Advanced' and 'MARC21' on 'Choose your setup' page 18. Notice that instead of bulletpoints there are now unselected radiobuttons under the 'default' heading on the 'Select default settings' page, and no radiobutton on this page is selected. i.e. the page should look similar to the screenshot under the '9.1.2. MARC21 Advanced setup' here: https://koha-community.org/manual/installation/html/web_installer_marc21_setup.html 19. Manually select all radiobuttons under the 'Default' heading and select 'Import' button Created attachment 62355 [details] [review] Bug 17855: Onboarding tool Created attachment 62356 [details] [review] Bug 18346 - Implemented basic and advanced setup modes for step 3 of the web installer 1. Drop and recreate your database 2. Clear memcached 3. Run through the web installer up to the start of step 3 4. Notice that the 'Choose your setup' page there are only 2 radiobutton options on the page: UNIMARC and MARC21 and neither are selected by default 5. Select MARC21 and click 'Next' 6. The 'Select default settings' page appears. Notice that the top checkboxes under the 'Mandatory' headings are selected by default (but can be unselected and checkboxes under the 'optional' header are not selected by default and can be selected 7. Do not select any checkboxes, leave the default checkboxes selected and click the 'Import' button 8. The 'Selected data added' page appears click 'Finish' button 9. Apply patch, also apply bug 18039 10. Repeat steps 1, and 3 11. Notice the 'Choose your setup' page has 4 radiobutton options, the two new options are 'Basic' and 'Advanced', with 'Basic' selected by default. Also notice that 'MARC21' radiobutton is selected by default. 12. Click 'Next' button 13. Notice on the 'Selecting default settings' page instead of default selected radiobuttons under the header of 'Mandatory' there are bulleted descriptions of files under the header 'Default'. As shown in the screenshots in the '9.1.1. MARC21 Basic setup' section of this document: https://koha-community.org/manual/installation/html/web_installer_marc21_setup.html Also notice as you scroll down there are unselected radiobuttons under the 'Optional' heading 14. Do not select anything and click the 'Import' button 15. The 'Selected data added' page appears click the 'Finish' button 16. Repeat steps 1,2,3 17. Select 'Advanced' and 'MARC21' on 'Choose your setup' page 18. Notice that instead of bulletpoints there are now unselected radiobuttons under the 'default' heading on the 'Select default settings' page, and no radiobutton on this page is selected. i.e. the page should look similar to the screenshot under the '9.1.2. MARC21 Advanced setup' here: https://koha-community.org/manual/installation/html/web_installer_marc21_setup.html 19. Manually select all radiobuttons under the 'Default' heading and select 'Import' button Created attachment 62357 [details] [review] Bug 18346 - Changed wording on button Adding Bug 18039 to 'Depends on' because needed by test plan step 9 Wanted to test, but I get merge conflicts. Tried following combinations: 1) 17855 18039 (as requested by test plan step #9) 18346 => lot of conflicts 2) 17855 ( Leave out 18039 (as requested by test plan step #9) ) 18346 => lot of conflicts Created attachment 62506 [details] [review] Bug 18346 - Implemented basic and advanced setup modes for step 3 of the web installer 1. Drop and recreate your database 2. Clear memcached 3. Run through the web installer up to the start of step 3 4. Notice that the 'Choose your setup' page there are only 2 radiobutton options on the page: UNIMARC and MARC21 and neither are selected by default 5. Select MARC21 and click 'Next' 6. The 'Select default settings' page appears. Notice that the top checkboxes under the 'Mandatory' headings are selected by default (but can be unselected and checkboxes under the 'optional' header are not selected by default and can be selected 7. Do not select any checkboxes, leave the default checkboxes selected and click the 'Import' button 8. The 'Selected data added' page appears click 'Finish' button 9. Apply patches attached to this bug report, also apply bug 18039 10. Repeat steps 1, and 3 11. Notice the 'Choose your setup' page has 4 radiobutton options, the two new options are 'Basic' and 'Advanced', with 'Basic' selected by default. Also notice that 'MARC21' radiobutton is selected by default. 12. Click 'Next' button 13. Notice on the 'Selecting default settings' page instead of default selected radiobuttons under the header of 'Mandatory' there are bulleted descriptions of files under the header 'Default'. As shown in the screenshots in the '9.1.1. MARC21 Basic setup' section of this document: https://koha-community.org/manual/installation/html/web_installer_marc21_setup.html Also notice as you scroll down there are unselected radiobuttons under the 'Optional' heading 14. Do not select anything and click the 'Import' button 15. The 'Selected data added' page appears click the 'Finish' button 16. Repeat steps 1,2,3 17. Select 'Advanced' and 'MARC21' on 'Choose your setup' page 18. Notice that instead of bulletpoints there are now unselected radiobuttons under the 'default' heading on the 'Select default settings' page, and no radiobutton on this page is selected. i.e. the page should look similar to the screenshot under the '9.1.2. MARC21 Advanced setup' here: https://koha-community.org/manual/installation/html/web_installer_marc21_setup.html 19. Manually select all radiobuttons under the 'Default' heading and select 'Import' button Created attachment 62507 [details] [review] Bug 18346 - Changed the button text at the end of the web installer to 'Finish' (In response to Marc Veron in comment 7) Hi Marc Sorry I incorrectly set this bug report as dependent on bug 17855 actually it does not need the onboarding tool functionality and just implements web installer improvements implementing a basic and advanced setup mode which is independent of bug 17855. Thus 17855 does not need to be applied at all. Therefore I have done some more work on the patches for this bug report and this bug report can be tested using the test plan in comment 8: Apply in this order please: 18346 18039 *** Bug 18470 has been marked as a duplicate of this bug. *** Something for the wishlist (for later): Have 3 buttons in 'Selecting default settings': - Select all options - Select mandatory options - Select optional options (In reply to Marc Véron from comment #12) > Something for the wishlist (for later): > > Have 3 buttons in 'Selecting default settings': > - Select all options > - Select mandatory options > - Select optional options ...or a button for each section. Some findings: - Select all button is missing in 'Basic setup', it appears in 'Advanced' only Ah, it appears in the second 'Optional' section only - Capitalisation of title 'Selecting Default Settings' (should be 'Selecting default settings' following the Koha rules) - I have the impression that the choices for 'Basic' and 'Advanced' are the same - Mandatory options are not pre-selected, is that intended? - When I click 'Import' and then go back with borwser back button and click 'Import' again, I end up with an 'Internal server error'. Of course one should not do that... But some people will do for sure... Will that mess up the db? - Maybe something for a new bug? Created attachment 63457 [details] [review] Bug 18346 - Merging the pushed onboarding tool with web imstaller improvements. Currently not all files in default and optional directories are being displayed I am currently working on this bug so please do not try testing the patches yet. |