Bug 18346 - Improved web installer containing basic and advanced setup modes
Summary: Improved web installer containing basic and advanced setup modes
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: 17.05
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Alex Buckley
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
: 18470 (view as bug list)
Depends on:
Blocks:
 
Reported: 2017-03-29 05:38 UTC by Alex Buckley
Modified: 2017-04-21 05:49 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 17855: Onboarding tool (105.10 KB, patch)
2017-03-29 05:43 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 18346 - Implemented basic and advanced setup modes for step 3 of the web installer (62.16 KB, patch)
2017-04-19 09:33 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 17855: Onboarding tool (105.14 KB, patch)
2017-04-19 09:39 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 18346 - Implemented basic and advanced setup modes for step 3 of the web installer (62.16 KB, patch)
2017-04-19 09:40 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 18346 - Changed wording on button (983 bytes, patch)
2017-04-19 09:46 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 18346 - Implemented basic and advanced setup modes for step 3 of the web installer (48.67 KB, patch)
2017-04-20 22:51 UTC, Alex Buckley
Details | Diff | Splinter Review
Bug 18346 - Changed the button text at the end of the web installer to 'Finish' (1.00 KB, patch)
2017-04-20 23:04 UTC, Alex Buckley
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Buckley 2017-03-29 05:38:46 UTC
This bug report contains the patch  that was attached to bug 17855 containing the improved web installer (which gives the users the options to either click the 'Basic' or 'Advanced' setup modes in step 3 of the web installer. The basic option displays all mandatory(default) data with an unselectable bullet-point and optional data with a selectable checkbox). 

Whilst the advanced setup mode displays all data values with a selectable checkbox. 

This bug report was created so that bug 17855 just contains the onboarding tool and so it does not need bug 18039 to be completed (moving mandatory SQL files for each language to a 'default' directory so they display correctly for the basic setup mode of the improved web installer)
Comment 1 Alex Buckley 2017-03-29 05:43:24 UTC
Created attachment 61666 [details] [review]
Bug 17855: Onboarding tool
Comment 2 Alex Buckley 2017-04-19 09:33:45 UTC
Created attachment 62354 [details] [review]
Bug 18346 - Implemented basic and advanced setup modes for step 3 of the web installer

1. Drop and recreate your database
2. Clear memcached
3. Run through the web installer up to the start of step 3
4. Notice that the 'Choose your setup' page there are only 2
radiobutton options on the page: UNIMARC and MARC21 and neither are
selected by default
5. Select MARC21 and click 'Next'
6. The 'Select default settings' page appears. Notice that the top
checkboxes under the 'Mandatory' headings are selected by default (but can
be unselected and checkboxes under the 'optional' header are not
selected by default and can be selected
7. Do not select any checkboxes, leave the default checkboxes selected
and click the 'Import' button
8. The 'Selected data added' page appears click 'Finish' button
9. Apply patch, also apply bug 18039
10. Repeat steps 1, and 3
11. Notice the 'Choose your setup' page has 4 radiobutton options, the
two new options are 'Basic' and 'Advanced', with 'Basic' selected by
default. Also notice that 'MARC21' radiobutton is selected by default.
12. Click 'Next' button
13. Notice on the 'Selecting default settings' page instead of default
selected radiobuttons under the header of 'Mandatory' there are bulleted
descriptions of files under the header 'Default'. As shown in the
screenshots in the '9.1.1. MARC21 Basic setup' section of this document: https://koha-community.org/manual/installation/html/web_installer_marc21_setup.html
Also notice as you scroll down there are unselected radiobuttons under
the 'Optional' heading
14. Do not select anything and click the 'Import' button
15. The 'Selected data added' page appears click the 'Finish' button
16. Repeat steps 1,2,3
17. Select 'Advanced' and 'MARC21' on 'Choose your setup' page
18. Notice that instead of bulletpoints there are now unselected
radiobuttons under the 'default' heading on the 'Select default
settings' page, and no radiobutton on this page is selected. i.e. the
page should look similar to the screenshot under the '9.1.2. MARC21
Advanced setup' here: https://koha-community.org/manual/installation/html/web_installer_marc21_setup.html
19. Manually select all radiobuttons under the 'Default' heading and
select 'Import' button
Comment 3 Alex Buckley 2017-04-19 09:39:31 UTC
Created attachment 62355 [details] [review]
Bug 17855: Onboarding tool
Comment 4 Alex Buckley 2017-04-19 09:40:15 UTC
Created attachment 62356 [details] [review]
Bug 18346 - Implemented basic and advanced setup modes for step 3 of the web installer

1. Drop and recreate your database
2. Clear memcached
3. Run through the web installer up to the start of step 3
4. Notice that the 'Choose your setup' page there are only 2
radiobutton options on the page: UNIMARC and MARC21 and neither are
selected by default
5. Select MARC21 and click 'Next'
6. The 'Select default settings' page appears. Notice that the top
checkboxes under the 'Mandatory' headings are selected by default (but can
be unselected and checkboxes under the 'optional' header are not
selected by default and can be selected
7. Do not select any checkboxes, leave the default checkboxes selected
and click the 'Import' button
8. The 'Selected data added' page appears click 'Finish' button
9. Apply patch, also apply bug 18039
10. Repeat steps 1, and 3
11. Notice the 'Choose your setup' page has 4 radiobutton options, the
two new options are 'Basic' and 'Advanced', with 'Basic' selected by
default. Also notice that 'MARC21' radiobutton is selected by default.
12. Click 'Next' button
13. Notice on the 'Selecting default settings' page instead of default
selected radiobuttons under the header of 'Mandatory' there are bulleted
descriptions of files under the header 'Default'. As shown in the
screenshots in the '9.1.1. MARC21 Basic setup' section of this document: https://koha-community.org/manual/installation/html/web_installer_marc21_setup.html
Also notice as you scroll down there are unselected radiobuttons under
the 'Optional' heading
14. Do not select anything and click the 'Import' button
15. The 'Selected data added' page appears click the 'Finish' button
16. Repeat steps 1,2,3
17. Select 'Advanced' and 'MARC21' on 'Choose your setup' page
18. Notice that instead of bulletpoints there are now unselected
radiobuttons under the 'default' heading on the 'Select default
settings' page, and no radiobutton on this page is selected. i.e. the
page should look similar to the screenshot under the '9.1.2. MARC21
Advanced setup' here: https://koha-community.org/manual/installation/html/web_installer_marc21_setup.html
19. Manually select all radiobuttons under the 'Default' heading and
select 'Import' button
Comment 5 Alex Buckley 2017-04-19 09:46:15 UTC
Created attachment 62357 [details] [review]
Bug 18346 - Changed wording on button
Comment 6 Marc Véron 2017-04-20 08:47:23 UTC
Adding Bug 18039 to 'Depends on' because needed by test plan step 9
Comment 7 Marc Véron 2017-04-20 09:04:25 UTC
Wanted to test, but I get merge conflicts.

Tried following combinations:

1)

17855
18039 (as requested by test plan step #9)
18346 => lot of conflicts

2)

17855
( Leave out 18039 (as requested by test plan step #9) )
18346 => lot of conflicts
Comment 8 Alex Buckley 2017-04-20 22:51:52 UTC
Created attachment 62506 [details] [review]
Bug 18346 - Implemented basic and advanced setup modes for step 3 of the web installer

1. Drop and recreate your database
2. Clear memcached
3. Run through the web installer up to the start of step 3
4. Notice that the 'Choose your setup' page there are only 2
radiobutton options on the page: UNIMARC and MARC21 and neither are
selected by default
5. Select MARC21 and click 'Next'
6. The 'Select default settings' page appears. Notice that the top
checkboxes under the 'Mandatory' headings are selected by default (but can
be unselected and checkboxes under the 'optional' header are not
selected by default and can be selected
7. Do not select any checkboxes, leave the default checkboxes selected
and click the 'Import' button
8. The 'Selected data added' page appears click 'Finish' button
9. Apply patches attached to this bug report, also apply bug 18039
10. Repeat steps 1, and 3
11. Notice the 'Choose your setup' page has 4 radiobutton options, the
two new options are 'Basic' and 'Advanced', with 'Basic' selected by
default. Also notice that 'MARC21' radiobutton is selected by default.
12. Click 'Next' button
13. Notice on the 'Selecting default settings' page instead of default
selected radiobuttons under the header of 'Mandatory' there are bulleted
descriptions of files under the header 'Default'. As shown in the
screenshots in the '9.1.1. MARC21 Basic setup' section of this document: https://koha-community.org/manual/installation/html/web_installer_marc21_setup.html
Also notice as you scroll down there are unselected radiobuttons under
the 'Optional' heading
14. Do not select anything and click the 'Import' button
15. The 'Selected data added' page appears click the 'Finish' button
16. Repeat steps 1,2,3
17. Select 'Advanced' and 'MARC21' on 'Choose your setup' page
18. Notice that instead of bulletpoints there are now unselected
radiobuttons under the 'default' heading on the 'Select default
settings' page, and no radiobutton on this page is selected. i.e. the
page should look similar to the screenshot under the '9.1.2. MARC21
Advanced setup' here: https://koha-community.org/manual/installation/html/web_installer_marc21_setup.html
19. Manually select all radiobuttons under the 'Default' heading and
select 'Import' button
Comment 9 Alex Buckley 2017-04-20 23:04:18 UTC
Created attachment 62507 [details] [review]
Bug 18346 - Changed the button text at the end of the web installer to 'Finish'
Comment 10 Alex Buckley 2017-04-20 23:13:48 UTC
(In response to Marc Veron in comment 7)
Hi Marc

Sorry I incorrectly set this bug report as dependent on bug 17855 actually it does not need the onboarding tool functionality and just implements web installer improvements implementing a basic and advanced setup mode which is independent of bug 17855. Thus 17855 does not need to be applied at all. 

Therefore I have done some more work on the patches for this bug report and this bug report can be tested using the test plan in comment 8:
Apply in this order please:

18346
18039
Comment 11 Marc Véron 2017-04-21 05:17:35 UTC
*** Bug 18470 has been marked as a duplicate of this bug. ***
Comment 12 Marc Véron 2017-04-21 05:22:45 UTC
Something for the wishlist (for later):

Have 3 buttons in 'Selecting default settings':
- Select all options
- Select mandatory options
- Select optional options
Comment 13 Marc Véron 2017-04-21 05:49:29 UTC
(In reply to Marc Véron from comment #12)
> Something for the wishlist (for later):
> 
> Have 3 buttons in 'Selecting default settings':
> - Select all options
> - Select mandatory options
> - Select optional options
...or a button for each section.

Some findings:

- Select all button is missing in 'Basic setup', it appears in 'Advanced' only
  Ah, it appears in the second 'Optional' section only

- Capitalisation of title 'Selecting Default Settings' (should be 'Selecting default settings' following the Koha rules)

- I have the impression that the choices for 'Basic' and 'Advanced' are the same

- Mandatory options are not pre-selected, is that intended?

- When I click 'Import' and then go back with borwser back button and click 'Import' again, I end up with an 'Internal server error'. Of course one should not do that... But some people will do for sure... Will that mess up the db? - Maybe something for a new bug?