| Summary: | transits are not created at check in despite user responsing Yes to the prompt | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Colin Campbell <colin.campbell> |
| Component: | Circulation | Assignee: | Owen Leonard <oleonard> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | major | ||
| Priority: | P5 - low | CC: | colin.campbell, gmcharlt, kyle.m.hall, kyle, mtj |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24085 | ||
| Change sponsored?: | --- | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | |||
| Bug Blocks: | 28064 | ||
| Attachments: |
Bug 18372 - transits are not created at check in despite user responsing Yes to the prompt
signed off patch Bug 18372 - transits are not created at check in despite user responsing Yes to the prompt |
||
|
Description
Colin Campbell
2017-04-03 15:25:58 UTC
setting version to 16.11 appears that master is not affected RMaint is watching... can we get a patch please? Can someone help me track the problem down here? Colin, can you upload a patch/diff please? Created attachment 62058 [details] [review] Bug 18372 - transits are not created at check in despite user responsing Yes to the prompt If the AutomaticItemReturn system preference is set to "Don't" and you check in an item which belongs to another library, a dialog will ask you if you want to transfer. This patch corrects a bug to enable the "Yes" buttons to work, triggering the transfer. To test, apply the patch and check in an item which belongs to another library. In the dialog, click the 'Yes' button and confirm that the item has been made 'in transit' to the correct library. Perform the same test with the 'Yes, print slip' and 'No' buttons and confirm they are working correctly. Since this patch changes the behavior of many other popups triggered from this template, test other operations which trigger a 'print slip' option like: - Checking in an item which is part of a rotating collection - Checking in an item which is on hold for a patron Created attachment 62073 [details] [review] signed off patch Is this only for 16.11? Sorry to be unclear. I found that the bug existed in master, and my patch is for master. If it doesn't apply to 16.11 I can submit another patch. The patch applies fine to 16.11 Can we please get QA on this? Created attachment 62414 [details] [review] Bug 18372 - transits are not created at check in despite user responsing Yes to the prompt If the AutomaticItemReturn system preference is set to "Don't" and you check in an item which belongs to another library, a dialog will ask you if you want to transfer. This patch corrects a bug to enable the "Yes" buttons to work, triggering the transfer. To test, apply the patch and check in an item which belongs to another library. In the dialog, click the 'Yes' button and confirm that the item has been made 'in transit' to the correct library. Perform the same test with the 'Yes, print slip' and 'No' buttons and confirm they are working correctly. Since this patch changes the behavior of many other popups triggered from this template, test other operations which trigger a 'print slip' option like: - Checking in an item which is part of a rotating collection - Checking in an item which is on hold for a patron Signed-off-by: Colin Campbell <colin.campbell@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Pushed to master for 17.05, thanks Owen! This patch has been pushed to 16.11.x and will be in 16.11.07. Glad this made it in on time! Pushed to 16.05.x, for 16.05.12 release |