Summary: | Test to ensure a system preference in .pref file also exists in sysprefs.sql | ||
---|---|---|---|
Product: | Koha | Reporter: | Lari Taskula <lari.taskula> |
Component: | Test Suite | Assignee: | Lari Taskula <lari.taskula> |
Status: | Failed QA --- | QA Contact: | Galen Charlton <gmcharlt> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | m.de.rooy, veron |
Version: | unspecified | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18444 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18513 |
||
GIT URL: | Change sponsored?: | --- | |
Patch complexity: | --- | Documentation contact: | |
Documentation submission: | Text to go in the release notes: | ||
Version(s) released in: | Circulation function: | ||
Attachments: | Bug 18446: Compare preferences in .pref files to sysprefs.sql |
Description
Lari Taskula
2017-04-18 14:35:09 UTC
Created attachment 62298 [details] [review] Bug 18446: Compare preferences in .pref files to sysprefs.sql This patch adds a test that reads system preferences from .pref files and checks that they are also defined in sysprefs.sql. To test: 1. prove t/db_dependent/check_sysprefs.t This test caught the following preferences: ArticleRequestsMandatoryFieldsItemOnly, HoldsInNoissuesCharge, NoRenewalBeforePrecision, OPACPopupAuthorsSearch, OPACPrivacy, OPACSuggestionMandatoryFields, OpacGroupResults, ReplytoDefault, SelfCheckoutByLogin, TalkingTechItivaPhoneNotification, marcflavour Add them to sysprefs.sql to make this test pass. There are a few exceptions like marcflavour (In reply to Marcel de Rooy from comment #3) > There are a few exceptions like marcflavour Should be filled by the user in the web installer. I think before this can go in, we need 2 things: - Exclude marcflavour as it is added and set by the web installer - Write a patch to add the missing preferences to syspref.sql and maybe also have an atomicupdate checking for their existence and adding when needed to get to a clean state. |