Extend t/db_dependent/check_sysprefs.t to read preferences from .pref files in order to check that they are also defined in installer/data/mysql/sysprefs.sql.
Created attachment 62298 [details] [review] Bug 18446: Compare preferences in .pref files to sysprefs.sql This patch adds a test that reads system preferences from .pref files and checks that they are also defined in sysprefs.sql. To test: 1. prove t/db_dependent/check_sysprefs.t
This test caught the following preferences: ArticleRequestsMandatoryFieldsItemOnly, HoldsInNoissuesCharge, NoRenewalBeforePrecision, OPACPopupAuthorsSearch, OPACPrivacy, OPACSuggestionMandatoryFields, OpacGroupResults, ReplytoDefault, SelfCheckoutByLogin, TalkingTechItivaPhoneNotification, marcflavour Add them to sysprefs.sql to make this test pass.
There are a few exceptions like marcflavour
(In reply to Marcel de Rooy from comment #3) > There are a few exceptions like marcflavour Should be filled by the user in the web installer.
I think before this can go in, we need 2 things: - Exclude marcflavour as it is added and set by the web installer - Write a patch to add the missing preferences to syspref.sql and maybe also have an atomicupdate checking for their existence and adding when needed to get to a clean state.