Bug 18449

Summary: Renewal limit button on renew.pl misleading
Product: Koha Reporter: Christopher Brannon <cbrannon>
Component: CirculationAssignee: Jonathan Druart <jonathan.druart>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: dominic.pichette, gmcharlt, jonathan.druart, katrin.fischer, kyle.m.hall
Version: MainKeywords: Academy
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: String patch
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Attachments: Bug 18449: Rename misleading button when renewing
Bug 18449: Rename misleading button when renewing
Bug 18449: Rename misleading button when renewing

Description Christopher Brannon 2017-04-18 17:50:37 UTC
If you hit the renewal limit on the renewal tab, the message gives you a message like:

"Windows 8 / ( 50610018249545 ) has been renewed the maximum number of times by Johnny Test ( 12345678 )"

And has a button that reads:

"Ignore and continue"

This button is misleading, as it may be interpreted as "ignore the limit and continue to renew the item".

I think the button needs to be relabeled: "Continue without renewing" or "Ok"
Comment 1 Jonathan Druart 2017-09-27 19:05:13 UTC
Created attachment 67413 [details] [review]
Bug 18449: Rename misleading button when renewing

If you hit the renewal limit on the renewal tab, the message gives you a
message like:

"Windows 8 / ( 50610018249545 ) has been renewed the maximum number of
times by Johnny Test ( 12345678 )"

And has a button that reads:

"Ignore and continue"

This button is misleading, as it may be interpreted as "ignore the limit
and continue to renew the item".
Comment 2 Dominic Pichette 2017-09-29 18:20:04 UTC
Created attachment 67483 [details] [review]
Bug 18449: Rename misleading button when renewing

If you hit the renewal limit on the renewal tab, the message gives you a
message like:

"Windows 8 / ( 50610018249545 ) has been renewed the maximum number of
times by Johnny Test ( 12345678 )"

And has a button that reads:

"Ignore and continue"

This button is misleading, as it may be interpreted as "ignore the limit
and continue to renew the item".

Signed-off-by: Dominic Pichette <dominic@inlibro.com>
Comment 3 Nick Clemens 2017-10-06 17:50:48 UTC
Created attachment 67754 [details] [review]
Bug 18449: Rename misleading button when renewing

If you hit the renewal limit on the renewal tab, the message gives you a
message like:

"Windows 8 / ( 50610018249545 ) has been renewed the maximum number of
times by Johnny Test ( 12345678 )"

And has a button that reads:

"Ignore and continue"

This button is misleading, as it may be interpreted as "ignore the limit
and continue to renew the item".

Signed-off-by: Dominic Pichette <dominic@inlibro.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Jonathan Druart 2017-10-09 19:17:38 UTC
Pushed to master for 17.11, thanks to everybody involved!