Bug 18449 - Renewal limit button on renew.pl misleading
Summary: Renewal limit button on renew.pl misleading
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Whiteboard:
Keywords: Academy
Depends on:
Blocks:
 
Reported: 2017-04-18 17:50 UTC by Christopher Brannon
Modified: 2017-10-09 19:17 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 18449: Rename misleading button when renewing (1.47 KB, patch)
2017-09-27 19:05 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 18449: Rename misleading button when renewing (1.52 KB, patch)
2017-09-29 18:20 UTC, Dominic Pichette
Details | Diff | Splinter Review
Bug 18449: Rename misleading button when renewing (1.58 KB, patch)
2017-10-06 17:50 UTC, Nick Clemens
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Christopher Brannon 2017-04-18 17:50:37 UTC
If you hit the renewal limit on the renewal tab, the message gives you a message like:

"Windows 8 / ( 50610018249545 ) has been renewed the maximum number of times by Johnny Test ( 12345678 )"

And has a button that reads:

"Ignore and continue"

This button is misleading, as it may be interpreted as "ignore the limit and continue to renew the item".

I think the button needs to be relabeled: "Continue without renewing" or "Ok"
Comment 1 Jonathan Druart 2017-09-27 19:05:13 UTC
Created attachment 67413 [details] [review]
Bug 18449: Rename misleading button when renewing

If you hit the renewal limit on the renewal tab, the message gives you a
message like:

"Windows 8 / ( 50610018249545 ) has been renewed the maximum number of
times by Johnny Test ( 12345678 )"

And has a button that reads:

"Ignore and continue"

This button is misleading, as it may be interpreted as "ignore the limit
and continue to renew the item".
Comment 2 Dominic Pichette 2017-09-29 18:20:04 UTC
Created attachment 67483 [details] [review]
Bug 18449: Rename misleading button when renewing

If you hit the renewal limit on the renewal tab, the message gives you a
message like:

"Windows 8 / ( 50610018249545 ) has been renewed the maximum number of
times by Johnny Test ( 12345678 )"

And has a button that reads:

"Ignore and continue"

This button is misleading, as it may be interpreted as "ignore the limit
and continue to renew the item".

Signed-off-by: Dominic Pichette <dominic@inlibro.com>
Comment 3 Nick Clemens 2017-10-06 17:50:48 UTC
Created attachment 67754 [details] [review]
Bug 18449: Rename misleading button when renewing

If you hit the renewal limit on the renewal tab, the message gives you a
message like:

"Windows 8 / ( 50610018249545 ) has been renewed the maximum number of
times by Johnny Test ( 12345678 )"

And has a button that reads:

"Ignore and continue"

This button is misleading, as it may be interpreted as "ignore the limit
and continue to renew the item".

Signed-off-by: Dominic Pichette <dominic@inlibro.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 4 Jonathan Druart 2017-10-09 19:17:38 UTC
Pushed to master for 17.11, thanks to everybody involved!