Bug 18466

Summary: No article requests breaks the opac-user-views block
Product: Koha Reporter: Eric Phetteplace <ephetteplace>
Component: OPACAssignee: Eric Phetteplace <ephetteplace>
Status: CLOSED FIXED QA Contact: Testopia <testopia>
Severity: trivial    
Priority: P5 - low CC: ephetteplace, jonathan.druart+koha, katrin.fischer, kyle, lmoran, mtj, veron
Version: master   
Hardware: All   
OS: All   
Change sponsored?: Sponsored Patch complexity: Trivial patch
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 14610    
Bug Blocks:    
Attachments: screenshot
Bug 18466: article requests box outline in opac
Bug 18466: article requests box outline in opac
Bug 18466: article requests box outline in opac

Description Eric Phetteplace 2017-04-21 00:12:56 UTC
Created attachment 62508 [details]
screenshot

If you have no open article requests, the tabbed box with checked out items, article requests. etc. just below the patron's name is awkward looking when you click on the article requests tab: the box below the tabs disappears because the way the `[% IF Koha.Preference('ArticleRequests') && IF borrower.article_requests_current.count %]` condition is written no table is printed at all.

Sorry if I'm articulating this poorly, a screenshot is attached.

Patch coming shortly, I'm just going to mimic the behavior of the checked out items section when there are no checked out items.
Comment 1 Eric Phetteplace 2017-04-21 00:26:00 UTC
Created attachment 62509 [details] [review]
Bug 18466: article requests box outline in opac
Comment 2 Marc Véron 2017-04-21 21:14:57 UTC
Could reproduce issue, with patch page looks much nicer.
QA tools complain because of line 818, but only change in this line is indentation. 

Signing off.
Comment 3 Marc Véron 2017-04-21 21:16:05 UTC
Created attachment 62563 [details] [review]
Bug 18466: article requests box outline in opac

To test:
1) apply patch
2) ensure ArticleRequests is set to Enable
3) sign in as a user with no article requests on the OPAC side
4) click the 'article requests' tab & see the box & message

Sponsored-By: California College of the Arts

Signed-off-by: Marc Véron <veron@veron.ch>
Comment 4 Eric Phetteplace 2017-04-21 22:21:17 UTC
Thanks, Marc!
Comment 5 Jonathan Druart 2017-04-24 16:35:03 UTC
Created attachment 62616 [details] [review]
Bug 18466: article requests box outline in opac

To test:
1) apply patch
2) ensure ArticleRequests is set to Enable
3) sign in as a user with no article requests on the OPAC side
4) click the 'article requests' tab & see the box & message

Sponsored-By: California College of the Arts

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 6 Kyle M Hall 2017-04-24 17:25:28 UTC
Pushed to master for 17.05, thanks Eric!
Comment 7 Katrin Fischer 2017-05-13 11:50:25 UTC
This patch has been pushed to 16.11.x and will be in 16.11.08.
Comment 8 Mason James 2017-05-23 23:28:44 UTC
Blocked by Enhancement (bz14610), skipping for 16.05.x