| Summary: | No article requests breaks the opac-user-views block | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Eric Phetteplace <ephetteplace> |
| Component: | OPAC | Assignee: | Eric Phetteplace <ephetteplace> |
| Status: | CLOSED FIXED | QA Contact: | Testopia <testopia> |
| Severity: | trivial | ||
| Priority: | P5 - low | CC: | ephetteplace, jonathan.druart, kyle, lmoran, mtj, veron |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
| Bug Depends on: | 14610 | ||
| Bug Blocks: | |||
| Attachments: |
screenshot
Bug 18466: article requests box outline in opac Bug 18466: article requests box outline in opac Bug 18466: article requests box outline in opac |
||
Created attachment 62509 [details] [review] Bug 18466: article requests box outline in opac Could reproduce issue, with patch page looks much nicer. QA tools complain because of line 818, but only change in this line is indentation. Signing off. Created attachment 62563 [details] [review] Bug 18466: article requests box outline in opac To test: 1) apply patch 2) ensure ArticleRequests is set to Enable 3) sign in as a user with no article requests on the OPAC side 4) click the 'article requests' tab & see the box & message Sponsored-By: California College of the Arts Signed-off-by: Marc Véron <veron@veron.ch> Thanks, Marc! Created attachment 62616 [details] [review] Bug 18466: article requests box outline in opac To test: 1) apply patch 2) ensure ArticleRequests is set to Enable 3) sign in as a user with no article requests on the OPAC side 4) click the 'article requests' tab & see the box & message Sponsored-By: California College of the Arts Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Pushed to master for 17.05, thanks Eric! This patch has been pushed to 16.11.x and will be in 16.11.08. Blocked by Enhancement (bz14610), skipping for 16.05.x |
Created attachment 62508 [details] screenshot If you have no open article requests, the tabbed box with checked out items, article requests. etc. just below the patron's name is awkward looking when you click on the article requests tab: the box below the tabs disappears because the way the `[% IF Koha.Preference('ArticleRequests') && IF borrower.article_requests_current.count %]` condition is written no table is printed at all. Sorry if I'm articulating this poorly, a screenshot is attached. Patch coming shortly, I'm just going to mimic the behavior of the checked out items section when there are no checked out items.