Description
Nick Clemens (kidclamp)
2017-04-21 14:22:40 UTC
I just had a staff member report this after our upgrade from 16.11 to 17.05 Looks like 17.05 broke a formerly good feature. Anyone interested in fixing it back? Please. NancyK Created attachment 70079 [details] [review] Bug 18474: Restore multiple holds when patron is searched for We lost the ability to place multiple holds when we are searching for patrons. The multi_holds parameter is lost and not handled correctly in the template. Test plan: - Make sure you can place multiple holds for a patron you will search for - Same for simple hold TODO the multiple holds view should not be displayed if only 1 record has been selected from the search result. I'd say that it is broken in all our supported branches. I had system error while testing on a sandbox, with the following message : Global symbol "$multihold" requires explicit package name (did you forget to declare "my $multihold"?) at /home/koha/src/reserve/request.pl line 129. Execution of /home/koha/src/reserve/request.pl aborted due to compilation errors. best regards Created attachment 72934 [details] [review] Bug 18474: Restore multiple holds when patron is searched for We lost the ability to place multiple holds when we are searching for patrons. The multi_holds parameter is lost and not handled correctly in the template. Test plan: - Make sure you can place multiple holds for a patron you will search for - Same for simple hold TODO the multiple holds view should not be displayed if only 1 record has been selected from the search result. Patch tested with a sandbox, by claude brayer <claude.brayer@cea.fr> Created attachment 73279 [details] [review] Bug 18474: Restore multiple holds when patron is searched for We lost the ability to place multiple holds when we are searching for patrons. The multi_holds parameter is lost and not handled correctly in the template. Test plan: - Make sure you can place multiple holds for a patron you will search for - Same for simple hold TODO the multiple holds view should not be displayed if only 1 record has been selected from the search result. Signed-off-by: claude brayer <claude.brayer@cea.fr> Created attachment 73464 [details] [review] Bug 18474: Restore multiple holds when patron is searched for We lost the ability to place multiple holds when we are searching for patrons. The multi_holds parameter is lost and not handled correctly in the template. Test plan: - Make sure you can place multiple holds for a patron you will search for - Same for simple hold TODO the multiple holds view should not be displayed if only 1 record has been selected from the search result. Signed-off-by: claude brayer <claude.brayer@cea.fr> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Created attachment 73465 [details] [review] Bug 18474 [QA Followup]: Remove useless else in template Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> *** Bug 20392 has been marked as a duplicate of this bug. *** Pushed to master for 18.05, thanks to everybody involved! Pushed to stable for 17.11.06 Awesome work all! Pushed to 17.05.x for v17.05.12 |