Bug 18533

Summary: MARC::Record->encoding does not handle UNIMARC records
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: MARC Bibliographic data supportAssignee: Galen Charlton <gmcharlt>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: phil
Version: unspecified   
Hardware: All   
OS: All   
See Also: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29333
GIT URL: Change sponsored?: ---
Patch complexity: --- Documentation contact:
Documentation submission: Text to go in the release notes:
Version(s) released in:
Circulation function:
Bug Depends on: 18152    
Bug Blocks: 18935    

Description Jonathan Druart 2017-05-03 17:57:49 UTC
Regarding bug 18152 MARC::Record->encoding should not be called directly from our codebase.
C4::Charset::SetMarcUnicodeFlag should call MARC::Record->encoding for MARC21 and NORMARC but does the UNIMARC trick for UNIMARC records.

It seems that MARC::Record->encoding calls should be replaced with C4::Charset::SetMarcUnicodeFlag everywhere.
Comment 1 Phil Ringnalda 2024-11-07 06:56:51 UTC
Given that bug 18152 was reverted, and calling C4::Charset::SetMarcUnicodeFlag actually calls MARC::Record->encoding even for UNIMARC, should this bug be closed, or should it be depending on another bug that will try again to do what bug 18152 failed to do?