Bug 18533 - MARC::Record->encoding does not handle UNIMARC records
Summary: MARC::Record->encoding does not handle UNIMARC records
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic data support (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Keywords:
Depends on: 18152
Blocks: 18935
  Show dependency treegraph
 
Reported: 2017-05-03 17:57 UTC by Jonathan Druart
Modified: 2024-11-07 06:56 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2017-05-03 17:57:49 UTC
Regarding bug 18152 MARC::Record->encoding should not be called directly from our codebase.
C4::Charset::SetMarcUnicodeFlag should call MARC::Record->encoding for MARC21 and NORMARC but does the UNIMARC trick for UNIMARC records.

It seems that MARC::Record->encoding calls should be replaced with C4::Charset::SetMarcUnicodeFlag everywhere.
Comment 1 Phil Ringnalda 2024-11-07 06:56:51 UTC
Given that bug 18152 was reverted, and calling C4::Charset::SetMarcUnicodeFlag actually calls MARC::Record->encoding even for UNIMARC, should this bug be closed, or should it be depending on another bug that will try again to do what bug 18152 failed to do?