| Summary: | Message "Patron's address in doubt" is confusing | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Barton Chittenden <barton> |
| Component: | Staff interface | Assignee: | Nick Clemens (kidclamp) <nick> |
| Status: | RESOLVED FIXED | QA Contact: | Katrin Fischer <katrin.fischer> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | arthur.suzuki, gmcharlt, lucas, nick, wainuiwitikapark |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| See Also: | https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31562 | ||
| Change sponsored?: | --- | Patch complexity: | Trivial patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: |
22.11.00, 22.05.08, 21.11.15
|
|
| Circulation function: | |||
| Attachments: |
Bug 18556: Clarify lost and gonenoaddress messages
Bug 18556: Clarify lost and gonenoaddress messages Bug 18556: Clarify lost and gonenoaddress messages |
||
|
Description
Barton Chittenden
2017-05-08 15:06:53 UTC
Maybe we should rename the flag too to make a bit easier to understand? Wrong address Wrong contact details Wrong address information ... ? Created attachment 140627 [details] [review] Bug 18556: Clarify lost and gonenoaddress messages This patch alters the message for the patron flasg slightly, and adds a title to provide explicit info when hoevered To test: 1 - Edit a patron and set gonenoaddress and lost flags 2 - Note new info in the flags section 3 - Go to 'Checkout' or 'Details' tab for patron 4 - Confirm the messages make sense 5 - Confirm you see a tool tip when hovering on messages Created attachment 140641 [details] [review] Bug 18556: Clarify lost and gonenoaddress messages This patch alters the message for the patron flasg slightly, and adds a title to provide explicit info when hoevered To test: 1 - Edit a patron and set gonenoaddress and lost flags 2 - Note new info in the flags section 3 - Go to 'Checkout' or 'Details' tab for patron 4 - Confirm the messages make sense 5 - Confirm you see a tool tip when hovering on messages Signed-off-by: David Nind <david@davidnind.com> I like the change in wording, but I am in doubt about removing the circ-hlt class as it appears in the CSS and in other messages shown in the patron account, so it's something they have in common right now. Maybe we should keep it? And something odd with and without the patch: If you go to a patron account and set both flags, only the first has the list > in the beginning. (In reply to Katrin Fischer from comment #4) > I like the change in wording, but I am in doubt about removing the circ-hlt > class as it appears in the CSS and in other messages shown in the patron > account, so it's something they have in common right now. Maybe we should > keep it? I don't remove it, it remains, one level down > And something odd with and without the patch: If you go to a patron account > and set both flags, only the first has the list > in the beginning. True before these patches too, something in the list markup maybe? Created attachment 142094 [details] [review] Bug 18556: Clarify lost and gonenoaddress messages This patch alters the message for the patron flasg slightly, and adds a title to provide explicit info when hoevered To test: 1 - Edit a patron and set gonenoaddress and lost flags 2 - Note new info in the flags section 3 - Go to 'Checkout' or 'Details' tab for patron 4 - Confirm the messages make sense 5 - Confirm you see a tool tip when hovering on messages Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> (In reply to Nick Clemens from comment #5) > (In reply to Katrin Fischer from comment #4) > > I like the change in wording, but I am in doubt about removing the circ-hlt > > class as it appears in the CSS and in other messages shown in the patron > > account, so it's something they have in common right now. Maybe we should > > keep it? > > I don't remove it, it remains, one level down > This is correct. Pushed to master for 22.11. Nice work everyone, thanks! Backported to 22.05.x for upcoming 22.05.08 applied to 21.11 for 21.11.15 Not backported to 21.05.x |