Bug 18559

Summary: Koha::Clubs - methods should not get the return type in parameter
Product: Koha Reporter: Jonathan Druart <jonathan.druart>
Component: Architecture, internals, and plumbingAssignee: Kyle M Hall <kyle>
Status: RESOLVED DUPLICATE QA Contact: Testopia <testopia>
Severity: normal    
Priority: P5 - low CC: kyle
Version: unspecified   
Hardware: All   
OS: All   
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on: 12461, 18553    
Bug Blocks:    
Attachments: Bug 18559: Koha::Clubs - Remove $return_scalar from parameters

Description Jonathan Druart 2017-05-08 18:48:18 UTC
Koha::Clubs->get_club_enrollments and Koha::Clubs->get_enrollable_clubs take a $return_scalar parameter.

The return value type should not be a parameter.
We should return _new_from_dbic or Koha::Objects->search in any cases.
Comment 1 Jonathan Druart 2017-05-08 18:50:18 UTC
Created attachment 63256 [details] [review]
Bug 18559: Koha::Clubs - Remove $return_scalar from parameters
Comment 2 Jonathan Druart 2017-05-08 18:50:38 UTC
Kyle, Here is my try.
But tests fail now...
Comment 3 Katrin Fischer 2023-09-15 20:08:00 UTC
(In reply to Jonathan Druart from comment #2)
> Kyle, Here is my try.
> But tests fail now...

Trying to raise attention - fqa.
Comment 4 Jonathan Druart 2023-09-18 17:09:24 UTC
Actually fixed on Bug 29844: Simplify Koha::Clubs->get_enrollable

*** This bug has been marked as a duplicate of bug 29844 ***