Bug 18559 - Koha::Clubs - methods should not get the return type in parameter
Summary: Koha::Clubs - methods should not get the return type in parameter
Status: RESOLVED DUPLICATE of bug 29844
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Kyle M Hall (khall)
QA Contact: Testopia
URL:
Keywords:
Depends on: 12461 18553
Blocks:
  Show dependency tree / graph
 
Reported: 2017-05-08 18:48 UTC by Jonathan Druart
Modified: 2023-09-18 17:09 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 18559: Koha::Clubs - Remove $return_scalar from parameters (9.85 KB, patch)
2017-05-08 18:50 UTC, Jonathan Druart 		Details | Diff | Splinter Review
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2017-05-08 18:48:18 UTC 
Koha::Clubs->get_club_enrollments and Koha::Clubs->get_enrollable_clubs take a $return_scalar parameter.

The return value type should not be a parameter.
We should return _new_from_dbic or Koha::Objects->search in any cases.
Comment 1 Jonathan Druart 2017-05-08 18:50:18 UTC 
Created attachment 63256 [details] [review]
Bug 18559: Koha::Clubs - Remove $return_scalar from parameters
Comment 2 Jonathan Druart 2017-05-08 18:50:38 UTC 
Kyle, Here is my try.
But tests fail now...
Comment 3 Katrin Fischer 2023-09-15 20:08:00 UTC 
(In reply to Jonathan Druart from comment #2)
> Kyle, Here is my try.
> But tests fail now...

Trying to raise attention - fqa.
Comment 4 Jonathan Druart 2023-09-18 17:09:24 UTC 
Actually fixed on Bug 29844: Simplify Koha::Clubs->get_enrollable

*** This bug has been marked as a duplicate of bug 29844 ***