Bug 18559 - Koha::Clubs - methods should not get the return type in parameter
Summary: Koha::Clubs - methods should not get the return type in parameter
Status: ASSIGNED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact: Testopia
URL:
Keywords:
Depends on: 12461 18553
Blocks:
  Show dependency treegraph
 
Reported: 2017-05-08 18:48 UTC by Jonathan Druart
Modified: 2017-05-08 18:50 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 18559: Koha::Clubs - Remove $return_scalar from parameters (9.85 KB, patch)
2017-05-08 18:50 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2017-05-08 18:48:18 UTC
Koha::Clubs->get_club_enrollments and Koha::Clubs->get_enrollable_clubs take a $return_scalar parameter.

The return value type should not be a parameter.
We should return _new_from_dbic or Koha::Objects->search in any cases.
Comment 1 Jonathan Druart 2017-05-08 18:50:18 UTC
Created attachment 63256 [details] [review]
Bug 18559: Koha::Clubs - Remove $return_scalar from parameters
Comment 2 Jonathan Druart 2017-05-08 18:50:38 UTC
Kyle, Here is my try.
But tests fail now...