Summary: | Use font awesome icons for plus signs in forms | ||
---|---|---|---|
Product: | Koha | Reporter: | Josef Moravec <josef.moravec> |
Component: | Templates | Assignee: | Josef Moravec <josef.moravec> |
Status: | RESOLVED FIXED | QA Contact: | Testopia <testopia> |
Severity: | enhancement | ||
Priority: | P5 - low | CC: | fridolin.somers, gmcharlt, oleonard |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | --- | Patch complexity: | --- |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Attachments: | Bug 18561: Use Font Awesome icons for plus (and minus) signs in forms |
Description
Josef Moravec
2017-05-09 14:00:55 UTC
Created attachment 63289 [details] [review] Bug 18561: Use Font Awesome icons for plus (and minus) signs in forms Test plan: 0. Apply the patch 1. Go to these forms and confirm that you can see new plus (minus) sign icon and that this cion does work as before - Acquisiton - search for orders form in header - Patrons - patron search in header - Advanced catalogue search - more options has to be activated - Opac - advanced search - more options has to be activated Owen, does it make sense to you? I think this would not work well with screen readers. I suppose they way it is right now (with a text +) is probably not great for screen readers either. Filament Group has a good reputation for thoughtful articles on this kind of thing: https://www.filamentgroup.com/lab/bulletproof_icon_fonts.html Their "Critical icons" section is interesting, but requires the js library Modernizr. I think this issue requires some more discussion and investigation. (In reply to Owen Leonard from comment #3) > I think this would not work well with screen readers. I suppose they way it > is right now (with a text +) is probably not great for screen readers either. > > Filament Group has a good reputation for thoughtful articles on this kind of > thing: > > https://www.filamentgroup.com/lab/bulletproof_icon_fonts.html > > Their "Critical icons" section is interesting, but requires the js library > Modernizr. > > I think this issue requires some more discussion and investigation. Good point Owen, thanks! Accessibility should be important for us of course... Indeed but a lot of the template use Font Awesome icons for important actions. Maybe using "title" attribute can provide an alternate text. My 2c As far as I could see, these templates have all been changed since. |