Bug 18561 - Use font awesome icons for plus signs in forms
Summary: Use font awesome icons for plus signs in forms
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Josef Moravec
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-09 14:00 UTC by Josef Moravec
Modified: 2023-09-15 20:35 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 18561: Use Font Awesome icons for plus (and minus) signs in forms (5.79 KB, patch)
2017-05-09 14:08 UTC, Josef Moravec
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Josef Moravec 2017-05-09 14:00:55 UTC

    
Comment 1 Josef Moravec 2017-05-09 14:08:36 UTC
Created attachment 63289 [details] [review]
Bug 18561: Use Font Awesome icons for plus (and minus) signs in forms

Test plan:
0. Apply the patch
1. Go to these forms and confirm that you can see new plus (minus) sign icon and
that this cion does work as before
    - Acquisiton - search for orders form in header
    - Patrons - patron search in header
    - Advanced catalogue search - more options has to be activated
    - Opac - advanced search - more options has to be activated
Comment 2 Josef Moravec 2017-05-09 14:09:33 UTC
Owen, does it make sense to you?
Comment 3 Owen Leonard 2017-05-09 14:50:37 UTC
I think this would not work well with screen readers. I suppose they way it is right now (with a text +) is probably not great for screen readers either.

Filament Group has a good reputation for thoughtful articles on this kind of thing:

https://www.filamentgroup.com/lab/bulletproof_icon_fonts.html

Their "Critical icons" section is interesting, but requires the js library Modernizr.

I think this issue requires some more discussion and investigation.
Comment 4 Josef Moravec 2017-05-09 16:10:40 UTC
(In reply to Owen Leonard from comment #3)
> I think this would not work well with screen readers. I suppose they way it
> is right now (with a text +) is probably not great for screen readers either.
> 
> Filament Group has a good reputation for thoughtful articles on this kind of
> thing:
> 
> https://www.filamentgroup.com/lab/bulletproof_icon_fonts.html
> 
> Their "Critical icons" section is interesting, but requires the js library
> Modernizr.
> 
> I think this issue requires some more discussion and investigation.

Good point Owen, thanks!

Accessibility should be important for us of course...
Comment 5 Fridolin Somers 2019-08-07 13:00:11 UTC
Indeed but a lot of the template use Font Awesome icons for important actions.

Maybe using "title" attribute can provide an alternate text.

My 2c
Comment 6 Katrin Fischer 2023-09-15 20:35:44 UTC
As far as I could see, these templates have all been changed since.