Bug 18587

Summary: LDAP: update_local is entirely untested!
Product: Koha Reporter: Martin Renvoize <martin.renvoize>
Component: AuthenticationAssignee: Galen Charlton <gmcharlt>
Status: NEW --- QA Contact: Testopia <testopia>
Severity: major    
Priority: P3 CC: dpavlin, gmcharlt, hblancoca, katrin.fischer, martin.renvoize, mtj, oliver.bock, tomascohen
Version: master   
Hardware: All   
OS: All   
Whiteboard:
Change sponsored?: --- Patch complexity: ---
Bot Control: --- When did the bot last check this:
Who signed the patch off: Text to go in the release notes:
Bug Depends on: 14625    
Bug Blocks:    

Description Martin Renvoize 2017-05-12 08:02:55 UTC
The update_local routine inside C4/Auth_with_ldap.pm is entirely untested :(.

Reading the code, there are assumptions within it that don't hold true either. For instance, it is assumed that the routine always returns 'cardnumber', when in fact, it can return 'undef' or an integer specifying the number of rows updated by the procedure.. which should only ever be '1'.