Bug 18587 - LDAP: update_local is entirely untested!
Summary: LDAP: update_local is entirely untested!
Status: NEW
Alias: None
Product: Koha
Classification: Unclassified
Component: Authentication (show other bugs)
Version: master
Hardware: All All
: P3 major (vote)
Assignee: Galen Charlton
QA Contact: Testopia
URL:
Whiteboard:
Keywords:
Depends on: 14625
Blocks:
  Show dependency treegraph
 
Reported: 2017-05-12 08:02 UTC by Martin Renvoize
Modified: 2017-05-12 08:02 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize 2017-05-12 08:02:55 UTC
The update_local routine inside C4/Auth_with_ldap.pm is entirely untested :(.

Reading the code, there are assumptions within it that don't hold true either. For instance, it is assumed that the routine always returns 'cardnumber', when in fact, it can return 'undef' or an integer specifying the number of rows updated by the procedure.. which should only ever be '1'.