Description
Eric Vantillard
2017-05-18 18:49:02 UTC
Created attachment 63548 [details] [review] Bug 18632: Remove 'CGI::param called in list context' warnings Once again, after bug 16154 and bug 16259 we need to remove more occurrence of CGi->param called in list context. Refer to bug 15809 for more information. Test plan: Make sure you do not see the error on the modified scripts. Created attachment 63610 [details] [review] [SIGNED-OFF] Bug 18632: Remove 'CGI::param called in list context' warnings Once again, after bug 16154 and bug 16259 we need to remove more occurrence of CGi->param called in list context. Refer to bug 15809 for more information. Test plan: Make sure you do not see the error on the modified scripts. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Created attachment 63727 [details] [review] Bug 18632: Remove 'CGI::param called in list context' warnings Once again, after bug 16154 and bug 16259 we need to remove more occurrence of CGi->param called in list context. Refer to bug 15809 for more information. Test plan: Make sure you do not see the error on the modified scripts. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Pushed to master for 17.05, thanks Jonathan! This doesn't apply cleanly to 16.11.x - I can remove the patron club related files, but not sure about the other conflicts. Please rebase! Can I get a rebased patch for 16.11.x please? Created attachment 65072 [details] [review] [16.11.x] Bug 18632: Remove 'CGI::param called in list context' warnings Once again, after bug 16154 and bug 16259 we need to remove more occurrence of CGi->param called in list context. Refer to bug 15809 for more information. Test plan: Make sure you do not see the error on the modified scripts. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Thx for the patch, Jonathan! This patch has been pushed to 16.11.x and will be in 16.11.11. Pushed to 16.05.x, for 16.05.16 release |