Bug 18632 - CGI::param called in list context flooding error logs
Summary: CGI::param called in list context flooding error logs
Status: Pushed to Master
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Whiteboard:
Keywords:
Depends on: 16154
Blocks: 18741
  Show dependency treegraph
 
Reported: 2017-05-18 18:49 UTC by Eric Vantillard
Modified: 2017-07-17 13:52 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Bot Control: ---
When did the bot last check this:
Who signed the patch off:
Text to go in the release notes:


Attachments
Bug 18632: Remove 'CGI::param called in list context' warnings (17.39 KB, patch)
2017-05-18 20:45 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 18632: Remove 'CGI::param called in list context' warnings (17.39 KB, patch)
2017-05-22 11:08 UTC, Josef Moravec
Details | Diff | Splinter Review
Bug 18632: Remove 'CGI::param called in list context' warnings (17.47 KB, patch)
2017-05-26 06:19 UTC, Marcel de Rooy
Details | Diff | Splinter Review
[16.11.x] Bug 18632: Remove 'CGI::param called in list context' warnings (13.80 KB, patch)
2017-07-17 13:52 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Vantillard 2017-05-18 18:49:02 UTC
see https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16154

Here are the error logs (I have removed duplicated errors)

authorised_values.pl: CGI::param called in list context from package main line 195, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/admin/authorised_values.pl
classsources.pl: CGI::param called in list context from package main line 68, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/admin/classsources.pl?op=edit_source&class_source=ddc
import_export_framework.pl: CGI::param called in list context from package main line 87, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/admin/biblio_framework.pl
install.pl: CGI::param called in list context from package main line 207, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/installer/install.pl
itemsearch.pl: CGI::param called in list context from package Template::Document line 118, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl
itemsearch.pl: CGI::param called in list context from package Template::Document line 370, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl
itemsearch.pl: CGI::param called in list context from package Template::Document line 375, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl
itemsearch.pl: CGI::param called in list context from package Template::Document line 41, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl
itemsearch.pl: CGI::param called in list context from package Template::Document line 43, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 436., referer: http://xxx/cgi-bin/koha/about.pl
Comment 1 Jonathan Druart 2017-05-18 20:45:43 UTC
Created attachment 63548 [details] [review]
Bug 18632: Remove 'CGI::param called in list context' warnings

Once again, after bug 16154 and bug 16259 we need to remove more
occurrence of CGi->param called in list context.
Refer to bug 15809 for more information.

Test plan:
Make sure you do not see the error on the modified scripts.
Comment 2 Josef Moravec 2017-05-22 11:08:37 UTC
Created attachment 63610 [details] [review]
[SIGNED-OFF] Bug 18632: Remove 'CGI::param called in list context' warnings

Once again, after bug 16154 and bug 16259 we need to remove more
occurrence of CGi->param called in list context.
Refer to bug 15809 for more information.

Test plan:
Make sure you do not see the error on the modified scripts.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Comment 3 Marcel de Rooy 2017-05-26 06:19:50 UTC
Created attachment 63727 [details] [review]
Bug 18632: Remove 'CGI::param called in list context' warnings

Once again, after bug 16154 and bug 16259 we need to remove more
occurrence of CGi->param called in list context.
Refer to bug 15809 for more information.

Test plan:
Make sure you do not see the error on the modified scripts.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Kyle M Hall 2017-05-29 02:25:42 UTC
Pushed to master for 17.05, thanks Jonathan!
Comment 5 Katrin Fischer 2017-06-05 12:49:20 UTC
This doesn't apply cleanly to 16.11.x - I can remove the patron club related files, but not sure about the other conflicts. Please rebase!
Comment 6 Katrin Fischer 2017-07-16 12:52:25 UTC
Can I get a rebased patch for 16.11.x please?
Comment 7 Jonathan Druart 2017-07-17 13:52:19 UTC
Created attachment 65072 [details] [review]
[16.11.x] Bug 18632: Remove 'CGI::param called in list context' warnings

Once again, after bug 16154 and bug 16259 we need to remove more
occurrence of CGi->param called in list context.
Refer to bug 15809 for more information.

Test plan:
Make sure you do not see the error on the modified scripts.

Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>