| Summary: | Barcode input filter not taken into consideration with batch | ||
|---|---|---|---|
| Product: | Koha | Reporter: | Blou <philippe.blouin> |
| Component: | Circulation | Assignee: | Blou <philippe.blouin> |
| Status: | CLOSED INVALID | QA Contact: | Testopia <testopia> |
| Severity: | normal | ||
| Priority: | P5 - low | CC: | gmcharlt, kyle, philippe.blouin |
| Version: | Main | ||
| Hardware: | All | ||
| OS: | All | ||
| GIT URL: | Initiative type: | --- | |
| Sponsorship status: | --- | Comma delimited list of Sponsors: | |
| Crowdfunding goal: | 0 | Patch complexity: | Small patch |
| Documentation contact: | Documentation submission: | ||
| Text to go in the release notes: | Version(s) released in: | ||
| Circulation function: | |||
Ok, this is a code 18. In normal circumstances (code not modified), would not happen. Code is ok. I would close it if I could, but can't. So here, Resolved-Invalid. Hope it's ok. |
circulation.pl was modified to handle barcode batches, but the code modifying the barcode is isolated and does not modify the batch. for my $barcode ( @$barcodes ) { $barcode =~ s/^\s*|\s*$//g; # remove leading/trailing whitespace $barcode = barcodedecode($barcode) if( $barcode && C4::Context->preference('itemBarcodeInputFilter')); } The local $barcode is modified, but not the array content. The issuing code later on just start with @$barcodes again, not with $barcode, so the modif is not even considered when using one barcode.